Skip to content
This repository has been archived by the owner on Jan 1, 2025. It is now read-only.

useRecoilTransaction_UNSTABLE() set does not run atom effects #1466

Closed
cqh963852 opened this issue Nov 26, 2021 · 3 comments
Closed

useRecoilTransaction_UNSTABLE() set does not run atom effects #1466

cqh963852 opened this issue Nov 26, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@cqh963852
Copy link

cqh963852 commented Nov 26, 2021

Hi I found that useRecoilTransaction_UNSTABLE 's transaction.set not trigger atomFamily's effect.

Here is the demo

codesandbox

Can any one help?

I don't want effect trigger by “get” after set action.

@cqh963852 cqh963852 changed the title useRecoilTransaction_UNSTABLE transaction.set not trigger effect [help] useRecoilTransaction_UNSTABLE transaction.set not trigger effect Nov 30, 2021
@drarmstr drarmstr self-assigned this Dec 1, 2021
@drarmstr drarmstr added the bug Something isn't working label Dec 1, 2021
@drarmstr
Copy link
Contributor

drarmstr commented Dec 1, 2021

This does not seem to be specific to atomFamily(). Fix coming shortly.

@drarmstr drarmstr changed the title [help] useRecoilTransaction_UNSTABLE transaction.set not trigger effect useRecoilTransaction_UNSTABLE transaction.set does not run atom effects Dec 1, 2021
@drarmstr drarmstr changed the title useRecoilTransaction_UNSTABLE transaction.set does not run atom effects useRecoilTransaction_UNSTABLE() set does not run atom effects Dec 1, 2021
drarmstr added a commit to drarmstr/Recoil that referenced this issue Dec 1, 2021
Summary:
Run atom effects when they are first used by being set from a transaction from `useRecoilTransaction_UNSTABLE()`.

Resolves facebookexperimental#1466

Differential Revision: D32777543

fbshipit-source-id: 37a22596413538828ddce6a8c0e8df802deb7b95
drarmstr added a commit to drarmstr/Recoil that referenced this issue Dec 3, 2021
Summary:
Run atom effects when they are first used by being set from a transaction from `useRecoilTransaction_UNSTABLE()`.

Resolves facebookexperimental#1466

Differential Revision: D32777543

fbshipit-source-id: 61331abb27abcfffbd4b4163c4494e972b84f73d
drarmstr added a commit to drarmstr/Recoil that referenced this issue Dec 3, 2021
Summary:
Run atom effects when they are first used by being set from a transaction from `useRecoilTransaction_UNSTABLE()`.

Resolves facebookexperimental#1466

Differential Revision: D32777543

fbshipit-source-id: e609949fdae8cf3a5d046eeb503a1f866d2a2f02
drarmstr added a commit to drarmstr/Recoil that referenced this issue Dec 3, 2021
Summary:
Run atom effects when they are first used by being set from a transaction from `useRecoilTransaction_UNSTABLE()`.

Resolves facebookexperimental#1466

Differential Revision: D32777543

fbshipit-source-id: 185ec0680a9aa28b7d6eadd8a35c7c8cd13c4ab1
drarmstr added a commit to drarmstr/Recoil that referenced this issue Dec 6, 2021
Summary:
Run atom effects when they are first used by being set from a transaction from `useRecoilTransaction_UNSTABLE()`.

Resolves facebookexperimental#1466

Differential Revision: D32777543

fbshipit-source-id: bee3fb7f5a62d282a18f0c414f6b0295c918a776
@dnsco
Copy link

dnsco commented Dec 6, 2021

I also just lost a couple hours to this, looking forward to the fix :)

Thanks again for this library.

@drarmstr
Copy link
Contributor

drarmstr commented Dec 7, 2021

I also just lost a couple hours to this, looking forward to the fix :)

Thanks again for this library.

Fix is #1479 if you want to patch it before it's merged and/or published.

drarmstr added a commit to drarmstr/Recoil that referenced this issue Dec 8, 2021
Summary:
Run atom effects when they are first used by being set from a transaction from `useRecoilTransaction_UNSTABLE()`.

Resolves facebookexperimental#1466

Differential Revision: D32777543

fbshipit-source-id: e68e973ae1601ab47e716741b3ef1d6339cd6478
drarmstr added a commit to drarmstr/Recoil that referenced this issue Dec 8, 2021
…okexperimental#1479)

Summary:
Pull Request resolved: facebookexperimental#1479

Run atom effects when they are first used by being set from a transaction from `useRecoilTransaction_UNSTABLE()`.

Resolves facebookexperimental#1466

Differential Revision: D32777543

fbshipit-source-id: d90de683f8ea33dcef3759c8e45eac8031408a1c
drarmstr added a commit to drarmstr/Recoil that referenced this issue Dec 8, 2021
Summary:
Run atom effects when they are first used by being set from a transaction from `useRecoilTransaction_UNSTABLE()`.

Resolves facebookexperimental#1466

Differential Revision: D32777543

fbshipit-source-id: 5ea8860c86f6f30bc3f66b1019f7056c9bb86b86
drarmstr added a commit to drarmstr/Recoil that referenced this issue Dec 8, 2021
Summary:
Run atom effects when they are first used by being set from a transaction from `useRecoilTransaction_UNSTABLE()`.

Resolves facebookexperimental#1466

Differential Revision: D32777543

fbshipit-source-id: fa6fa4faf67a7c73f0ddc604fe7693a584aa0402
drarmstr added a commit to drarmstr/Recoil that referenced this issue Dec 8, 2021
Summary:
Run atom effects when they are first used by being set from a transaction from `useRecoilTransaction_UNSTABLE()`.

Resolves facebookexperimental#1466

Differential Revision: D32777543

fbshipit-source-id: 562c8730fa483cc19c36a78733760b181f275a59
drarmstr added a commit to drarmstr/Recoil that referenced this issue Dec 8, 2021
Summary:
Run atom effects when they are first used by being set from a transaction from `useRecoilTransaction_UNSTABLE()`.

Resolves facebookexperimental#1466

Differential Revision: D32777543

fbshipit-source-id: e18e5986fe95a2fc9841937345127c3ca9a9cd48
drarmstr added a commit to drarmstr/Recoil that referenced this issue Dec 8, 2021
Summary:
Run atom effects when they are first used by being set from a transaction from `useRecoilTransaction_UNSTABLE()`.

Resolves facebookexperimental#1466

Differential Revision: D32777543

fbshipit-source-id: 373778f26ea5c2fcd10869907aad1c101256a269
drarmstr added a commit to drarmstr/Recoil that referenced this issue Dec 9, 2021
Summary:
Run atom effects when they are first used by being set from a transaction from `useRecoilTransaction_UNSTABLE()`.

Resolves facebookexperimental#1466

Differential Revision: D32777543

fbshipit-source-id: 1d4e0e3bd7849e0374234b3cf8ce8697f5fae67f
drarmstr added a commit to drarmstr/Recoil that referenced this issue Dec 9, 2021
…okexperimental#1479)

Summary:
Pull Request resolved: facebookexperimental#1479

Run atom effects when they are first used by being set from a transaction from `useRecoilTransaction_UNSTABLE()`.

Resolves facebookexperimental#1466

Differential Revision: D32777543

fbshipit-source-id: 3927953f5f2287b52a0c2ba9941373ccd19e6c1c
drarmstr added a commit to drarmstr/Recoil that referenced this issue Dec 9, 2021
Summary:
Run atom effects when they are first used by being set from a transaction from `useRecoilTransaction_UNSTABLE()`.

Resolves facebookexperimental#1466

Differential Revision: D32777543

fbshipit-source-id: 5c244437576246a3b79df75e0341641e964b666a
drarmstr added a commit to drarmstr/Recoil that referenced this issue Dec 9, 2021
Summary:
Run atom effects when they are first used by being set from a transaction from `useRecoilTransaction_UNSTABLE()`.

Resolves facebookexperimental#1466

Differential Revision: D32777543

fbshipit-source-id: c4145275b76bf3832148365150655265e9e87eed
drarmstr added a commit to drarmstr/Recoil that referenced this issue Dec 9, 2021
Summary:
Run atom effects when they are first used by being set from a transaction from `useRecoilTransaction_UNSTABLE()`.

Resolves facebookexperimental#1466

Differential Revision: D32777543

fbshipit-source-id: 664f3f445ddb9315ce8b3514c13fa5fcd475837f
drarmstr added a commit to drarmstr/Recoil that referenced this issue Dec 9, 2021
Summary:
Run atom effects when they are first used by being set from a transaction from `useRecoilTransaction_UNSTABLE()`.

Resolves facebookexperimental#1466

Differential Revision: D32777543

fbshipit-source-id: 9f9260311a3b6d94300f1605ddacf9f8abd3d0b0
drarmstr added a commit to drarmstr/Recoil that referenced this issue Dec 9, 2021
Summary:
Run atom effects when they are first used by being set from a transaction from `useRecoilTransaction_UNSTABLE()`.

Resolves facebookexperimental#1466

Differential Revision: D32777543

fbshipit-source-id: febb1a8d1d36f08eb4af6f380081f12c10037127
drarmstr added a commit to drarmstr/Recoil that referenced this issue Dec 9, 2021
Summary:
Run atom effects when they are first used by being set from a transaction from `useRecoilTransaction_UNSTABLE()`.

Resolves facebookexperimental#1466

Differential Revision: D32777543

fbshipit-source-id: 304f92b12fab2f7d47d06f1501900fe4d4a4f793
drarmstr added a commit to drarmstr/Recoil that referenced this issue Dec 9, 2021
…okexperimental#1479)

Summary:
Pull Request resolved: facebookexperimental#1479

Run atom effects when they are first used by being set from a transaction from `useRecoilTransaction_UNSTABLE()`.

Resolves facebookexperimental#1466

Differential Revision: D32777543

fbshipit-source-id: 82c966f7a8af94855913f7a6a81b5fff93b9e253
drarmstr added a commit to drarmstr/Recoil that referenced this issue Dec 9, 2021
Summary:
Run atom effects when they are first used by being set from a transaction from `useRecoilTransaction_UNSTABLE()`.

Resolves facebookexperimental#1466

Differential Revision: D32777543

fbshipit-source-id: df83de3e1d19f25a544911c87de35a53fb75e75f
drarmstr added a commit to drarmstr/Recoil that referenced this issue Dec 14, 2021
Summary:
Run atom effects when they are first used by being set from a transaction from `useRecoilTransaction_UNSTABLE()`.

Resolves facebookexperimental#1466

Differential Revision: D32777543

fbshipit-source-id: 589ed0ab5c4af1d39f68c40be85a4e5e43ebb193
drarmstr added a commit to drarmstr/Recoil that referenced this issue Dec 14, 2021
…okexperimental#1479)

Summary:
Pull Request resolved: facebookexperimental#1479

Run atom effects when they are first used by being set from a transaction from `useRecoilTransaction_UNSTABLE()`.

Resolves facebookexperimental#1466

Reviewed By: habond, mondaychen

Differential Revision: D32777543

fbshipit-source-id: b20cd0d2cbf2dce5bd617c217e1c01974d7c2472
drarmstr added a commit to drarmstr/Recoil that referenced this issue Dec 14, 2021
Summary:
Run atom effects when they are first used by being set from a transaction from `useRecoilTransaction_UNSTABLE()`.

Resolves facebookexperimental#1466

Differential Revision: D32777543

fbshipit-source-id: e405341646d7a28155fe6b56426d7a6b24630171
drarmstr added a commit to drarmstr/Recoil that referenced this issue Dec 14, 2021
Summary:
Run atom effects when they are first used by being set from a transaction from `useRecoilTransaction_UNSTABLE()`.

Resolves facebookexperimental#1466

Differential Revision: D32777543

fbshipit-source-id: c5b95bf0961e519053658397b94774adc8c33e05
drarmstr added a commit to drarmstr/Recoil that referenced this issue Dec 14, 2021
Summary:
Run atom effects when they are first used by being set from a transaction from `useRecoilTransaction_UNSTABLE()`.

Resolves facebookexperimental#1466

Differential Revision: D32777543

fbshipit-source-id: 5f754a0aeb4c1465330355f25c084c24c8643bfe
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants