This repository has been archived by the owner on Jan 1, 2025. It is now read-only.
Run atom effect when first used by setting from a transaction #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D32777543 |
drarmstr
added a commit
to drarmstr/Recoil
that referenced
this pull request
Dec 8, 2021
…okexperimental#1479) Summary: Pull Request resolved: facebookexperimental#1479 Run atom effects when they are first used by being set from a transaction from `useRecoilTransaction_UNSTABLE()`. Resolves facebookexperimental#1466 Differential Revision: D32777543 fbshipit-source-id: d90de683f8ea33dcef3759c8e45eac8031408a1c
drarmstr
force-pushed
the
export-D32777543
branch
from
cef688f to
02e0dfd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D32777543 |
drarmstr
added a commit
to drarmstr/Recoil
that referenced
this pull request
Dec 9, 2021
…okexperimental#1479) Summary: Pull Request resolved: facebookexperimental#1479 Run atom effects when they are first used by being set from a transaction from `useRecoilTransaction_UNSTABLE()`. Resolves facebookexperimental#1466 Differential Revision: D32777543 fbshipit-source-id: 3927953f5f2287b52a0c2ba9941373ccd19e6c1c
drarmstr
force-pushed
the
export-D32777543
branch
from
02e0dfd to
c57fdaa
Compare
|
This pull request was exported from Phabricator. Differential Revision: D32777543 |
drarmstr
added a commit
to drarmstr/Recoil
that referenced
this pull request
Dec 9, 2021
…okexperimental#1479) Summary: Pull Request resolved: facebookexperimental#1479 Run atom effects when they are first used by being set from a transaction from `useRecoilTransaction_UNSTABLE()`. Resolves facebookexperimental#1466 Differential Revision: D32777543 fbshipit-source-id: 82c966f7a8af94855913f7a6a81b5fff93b9e253
|
This pull request was exported from Phabricator. Differential Revision: D32777543 |
drarmstr
force-pushed
the
export-D32777543
branch
from
c57fdaa to
b6d43a8
Compare
Summary: Add unit tests for getting/setting atoms via `useRecoilTransaction_UNSTABLE()` NOTE: Not sure how to test setting an atom as Jest is complaining about updates not wrapped in `act(...)`... Differential Revision: D32774468 fbshipit-source-id: 26c6a35ecaafee93b74adbc32f4581d547d5f738
…okexperimental#1479) Summary: Pull Request resolved: facebookexperimental#1479 Run atom effects when they are first used by being set from a transaction from `useRecoilTransaction_UNSTABLE()`. Resolves facebookexperimental#1466 Reviewed By: habond, mondaychen Differential Revision: D32777543 fbshipit-source-id: b20cd0d2cbf2dce5bd617c217e1c01974d7c2472
drarmstr
force-pushed
the
export-D32777543
branch
from
b6d43a8 to
ef8a21b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D32777543 |
AlexGuz23
pushed a commit
to AlexGuz23/Recoil
that referenced
this pull request
Nov 3, 2022
Summary: Pull Request resolved: facebookexperimental/Recoil#1479 Run atom effects when they are first used by being set from a transaction from `useRecoilTransaction_UNSTABLE()`. Resolves #1466 Reviewed By: habond, mondaychen Differential Revision: D32777543 fbshipit-source-id: c2e4d7b618281325beb24d11d7f6ba0b8ce6f317
snipershooter0701
pushed a commit
to snipershooter0701/Recoil
that referenced
this pull request
Mar 5, 2023
Summary: Pull Request resolved: facebookexperimental/Recoil#1479 Run atom effects when they are first used by being set from a transaction from `useRecoilTransaction_UNSTABLE()`. Resolves #1466 Reviewed By: habond, mondaychen Differential Revision: D32777543 fbshipit-source-id: c2e4d7b618281325beb24d11d7f6ba0b8ce6f317
eagle2722
added a commit
to eagle2722/Recoil
that referenced
this pull request
Sep 21, 2024
Summary: Pull Request resolved: facebookexperimental/Recoil#1479 Run atom effects when they are first used by being set from a transaction from `useRecoilTransaction_UNSTABLE()`. Resolves #1466 Reviewed By: habond, mondaychen Differential Revision: D32777543 fbshipit-source-id: c2e4d7b618281325beb24d11d7f6ba0b8ce6f317
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Run atom effects when they are first used by being set from a transaction from
useRecoilTransaction_UNSTABLE().Resolves #1466
Differential Revision: D32777543