Fix - openChrome won't open default browser (using Canary) #1215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use “Chrome” instead of "Google Chrome", It will try to use current active browser. otherwise, use default. - If “Chrome”s aren’t running, will fallback to opn(url)
Merged
alexdriaguine
pushed a commit
to alexdriaguine/create-react-app
that referenced
this pull request
Jan 23, 2017
…1215) - Use “Chrome” instead of "Google Chrome", It will try to use current active browser. otherwise, use default. - If “Chrome”s aren’t running, will fallback to opn(url)
randycoulman
pushed a commit
to CodingZeal/create-react-app
that referenced
this pull request
May 8, 2017
…1215) - Use “Chrome” instead of "Google Chrome", It will try to use current active browser. otherwise, use default. - If “Chrome”s aren’t running, will fallback to opn(url)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1213
I accidentally changed "Chrome" to "Google Chrome" in #1165. It forces to open Chrome Stable instead of default browser in system-wide (eg. Chrome Canary).