Store std::exception_ptr on EvalCtx.errors #157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: EvalCtx.errors used to store only the exception strings found when evaluation expressions, and hence, if the exception had to be re-thrown, the original exception type would be lost. Changing the vector to capture the whole exception (via std::exception_ptr) instead. This uses an opaque type flat vector to store the exception objects. Reviewed By: mbasmanova Differential Revision: D30709206 fbshipit-source-id: 863ace53ca3a487ce17c7f35be8961caf177105d
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D30709206 |
|
This pull request has been merged in 9043e53. |
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Mar 17, 2023
liujiayi771
pushed a commit
to liujiayi771/velox
that referenced
this pull request
Mar 29, 2023
liujiayi771
pushed a commit
to liujiayi771/velox
that referenced
this pull request
Apr 1, 2023
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Apr 23, 2023
zhouyuan
pushed a commit
to zhouyuan/velox
that referenced
this pull request
Jun 7, 2023
relative pr: Fix replace SparkSQL function facebookincubator#277 Support kPreceeding & kFollowing for window range frame type facebookincubator#287 support timestamp hash facebookincubator#269 Spark sum can overflow facebookincubator#101 Support float & double types in pmod function facebookincubator#157 Implement datetime functions in velox/sparksql. facebookincubator#81 Fix type check in MapFunction facebookincubator#273 Let function validation fail for lookaround pattern in RE2-based implementation facebookincubator#124 Register lpad/rpad functions for Spark SQL. facebookincubator#63 Support substring_index sql function facebookincubator#189 Fix First/Last aggregate functions intermediate type and support decimal facebookincubator#245 Support date_add spark sql function facebookincubator#144
Yohahaha
pushed a commit
to Yohahaha/velox
that referenced
this pull request
Jul 4, 2023
relative pr: Fix replace SparkSQL function facebookincubator#277 Support kPreceeding & kFollowing for window range frame type facebookincubator#287 support timestamp hash facebookincubator#269 Spark sum can overflow facebookincubator#101 Support float & double types in pmod function facebookincubator#157 Implement datetime functions in velox/sparksql. facebookincubator#81 Fix type check in MapFunction facebookincubator#273 Let function validation fail for lookaround pattern in RE2-based implementation facebookincubator#124 Register lpad/rpad functions for Spark SQL. facebookincubator#63 Support substring_index sql function facebookincubator#189 Fix First/Last aggregate functions intermediate type and support decimal facebookincubator#245 Support date_add spark sql function facebookincubator#144
chenxu14
pushed a commit
to chenxu14/velox
that referenced
this pull request
Jul 5, 2023
relative pr: Fix replace SparkSQL function facebookincubator#277 Support kPreceeding & kFollowing for window range frame type facebookincubator#287 support timestamp hash facebookincubator#269 Spark sum can overflow facebookincubator#101 Support float & double types in pmod function facebookincubator#157 Implement datetime functions in velox/sparksql. facebookincubator#81 Fix type check in MapFunction facebookincubator#273 Let function validation fail for lookaround pattern in RE2-based implementation facebookincubator#124 Register lpad/rpad functions for Spark SQL. facebookincubator#63 Support substring_index sql function facebookincubator#189 Fix First/Last aggregate functions intermediate type and support decimal facebookincubator#245 Support date_add spark sql function facebookincubator#144
PHILO-HE
pushed a commit
to PHILO-HE/velox
that referenced
this pull request
Jul 17, 2023
relative pr: Fix replace SparkSQL function facebookincubator#277 Support kPreceeding & kFollowing for window range frame type facebookincubator#287 support timestamp hash facebookincubator#269 Spark sum can overflow facebookincubator#101 Support float & double types in pmod function facebookincubator#157 Implement datetime functions in velox/sparksql. facebookincubator#81 Fix type check in MapFunction facebookincubator#273 Let function validation fail for lookaround pattern in RE2-based implementation facebookincubator#124 Register lpad/rpad functions for Spark SQL. facebookincubator#63 Support substring_index sql function facebookincubator#189 Fix First/Last aggregate functions intermediate type and support decimal facebookincubator#245 Support date_add spark sql function facebookincubator#144
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Jul 21, 2023
relative pr: Fix replace SparkSQL function facebookincubator#277 Support kPreceeding & kFollowing for window range frame type facebookincubator#287 support timestamp hash facebookincubator#269 Spark sum can overflow facebookincubator#101 Support float & double types in pmod function facebookincubator#157 Implement datetime functions in velox/sparksql. facebookincubator#81 Fix type check in MapFunction facebookincubator#273 Let function validation fail for lookaround pattern in RE2-based implementation facebookincubator#124 Register lpad/rpad functions for Spark SQL. facebookincubator#63 Support substring_index sql function facebookincubator#189 Fix First/Last aggregate functions intermediate type and support decimal facebookincubator#245 Support date_add spark sql function facebookincubator#144
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Jul 24, 2023
relative pr: Fix replace SparkSQL function facebookincubator#277 Support kPreceeding & kFollowing for window range frame type facebookincubator#287 support timestamp hash facebookincubator#269 Spark sum can overflow facebookincubator#101 Support float & double types in pmod function facebookincubator#157 Implement datetime functions in velox/sparksql. facebookincubator#81 Fix type check in MapFunction facebookincubator#273 Let function validation fail for lookaround pattern in RE2-based implementation facebookincubator#124 Register lpad/rpad functions for Spark SQL. facebookincubator#63 Support substring_index sql function facebookincubator#189 Fix First/Last aggregate functions intermediate type and support decimal facebookincubator#245 Support date_add spark sql function facebookincubator#144
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
EvalCtx.errors used to store only the exception strings found when
evaluation expressions, and hence, if the exception had to be re-thrown, the
original exception type would be lost. Changing the vector to capture the whole
exception (via std::exception_ptr) instead.
This uses an opaque type flat vector to store the exception objects.
Reviewed By: mbasmanova
Differential Revision: D30709206