Add width_bucket function with bins array #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@shixuan-fan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
mbasmanova
reviewed
Aug 18, 2021
Will do. Sorry missed that :) |
mbasmanova
reviewed
Aug 24, 2021
There was a problem hiding this comment.
@shixuan-fan Looks great. Just a few nits and one comment on error reporting.
|
There are some major changes after changing it to be a stateful vector, so another round of review would be appreciated :) Also, the TODO I have in test might not be legit. It might just be due to my lack of knowledge on how to implement them. |
mbasmanova
reviewed
Aug 27, 2021
This was referenced Aug 30, 2021
mbasmanova
reviewed
Aug 30, 2021
mbasmanova
approved these changes
Aug 31, 2021
|
@shixuan-fan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Pull Request resolved: #63 Reviewed By: mbasmanova Differential Revision: D30402055 Pulled By: shixuan-fan fbshipit-source-id: dff5b88a0b022cc8371b5fb26634c0046755b812
|
This pull request was exported from Phabricator. Differential Revision: D30402055 |
|
@shixuan-fan merged this pull request in d1708eb. |
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Nov 14, 2022
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Nov 22, 2022
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Dec 15, 2022
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Jan 6, 2023
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Jan 12, 2023
PHILO-HE
pushed a commit
to PHILO-HE/velox
that referenced
this pull request
Feb 3, 2023
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Feb 24, 2023
liujiayi771
pushed a commit
to liujiayi771/velox
that referenced
this pull request
Mar 3, 2023
liujiayi771
pushed a commit
to liujiayi771/velox
that referenced
this pull request
Mar 9, 2023
liujiayi771
pushed a commit
to liujiayi771/velox
that referenced
this pull request
Apr 1, 2023
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Apr 23, 2023
zhouyuan
pushed a commit
to zhouyuan/velox
that referenced
this pull request
Jun 7, 2023
relative pr: Fix replace SparkSQL function facebookincubator#277 Support kPreceeding & kFollowing for window range frame type facebookincubator#287 support timestamp hash facebookincubator#269 Spark sum can overflow facebookincubator#101 Support float & double types in pmod function facebookincubator#157 Implement datetime functions in velox/sparksql. facebookincubator#81 Fix type check in MapFunction facebookincubator#273 Let function validation fail for lookaround pattern in RE2-based implementation facebookincubator#124 Register lpad/rpad functions for Spark SQL. facebookincubator#63 Support substring_index sql function facebookincubator#189 Fix First/Last aggregate functions intermediate type and support decimal facebookincubator#245 Support date_add spark sql function facebookincubator#144
Yohahaha
pushed a commit
to Yohahaha/velox
that referenced
this pull request
Jul 4, 2023
relative pr: Fix replace SparkSQL function facebookincubator#277 Support kPreceeding & kFollowing for window range frame type facebookincubator#287 support timestamp hash facebookincubator#269 Spark sum can overflow facebookincubator#101 Support float & double types in pmod function facebookincubator#157 Implement datetime functions in velox/sparksql. facebookincubator#81 Fix type check in MapFunction facebookincubator#273 Let function validation fail for lookaround pattern in RE2-based implementation facebookincubator#124 Register lpad/rpad functions for Spark SQL. facebookincubator#63 Support substring_index sql function facebookincubator#189 Fix First/Last aggregate functions intermediate type and support decimal facebookincubator#245 Support date_add spark sql function facebookincubator#144
chenxu14
pushed a commit
to chenxu14/velox
that referenced
this pull request
Jul 5, 2023
relative pr: Fix replace SparkSQL function facebookincubator#277 Support kPreceeding & kFollowing for window range frame type facebookincubator#287 support timestamp hash facebookincubator#269 Spark sum can overflow facebookincubator#101 Support float & double types in pmod function facebookincubator#157 Implement datetime functions in velox/sparksql. facebookincubator#81 Fix type check in MapFunction facebookincubator#273 Let function validation fail for lookaround pattern in RE2-based implementation facebookincubator#124 Register lpad/rpad functions for Spark SQL. facebookincubator#63 Support substring_index sql function facebookincubator#189 Fix First/Last aggregate functions intermediate type and support decimal facebookincubator#245 Support date_add spark sql function facebookincubator#144
PHILO-HE
pushed a commit
to PHILO-HE/velox
that referenced
this pull request
Jul 17, 2023
relative pr: Fix replace SparkSQL function facebookincubator#277 Support kPreceeding & kFollowing for window range frame type facebookincubator#287 support timestamp hash facebookincubator#269 Spark sum can overflow facebookincubator#101 Support float & double types in pmod function facebookincubator#157 Implement datetime functions in velox/sparksql. facebookincubator#81 Fix type check in MapFunction facebookincubator#273 Let function validation fail for lookaround pattern in RE2-based implementation facebookincubator#124 Register lpad/rpad functions for Spark SQL. facebookincubator#63 Support substring_index sql function facebookincubator#189 Fix First/Last aggregate functions intermediate type and support decimal facebookincubator#245 Support date_add spark sql function facebookincubator#144
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Jul 21, 2023
relative pr: Fix replace SparkSQL function facebookincubator#277 Support kPreceeding & kFollowing for window range frame type facebookincubator#287 support timestamp hash facebookincubator#269 Spark sum can overflow facebookincubator#101 Support float & double types in pmod function facebookincubator#157 Implement datetime functions in velox/sparksql. facebookincubator#81 Fix type check in MapFunction facebookincubator#273 Let function validation fail for lookaround pattern in RE2-based implementation facebookincubator#124 Register lpad/rpad functions for Spark SQL. facebookincubator#63 Support substring_index sql function facebookincubator#189 Fix First/Last aggregate functions intermediate type and support decimal facebookincubator#245 Support date_add spark sql function facebookincubator#144
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Jul 24, 2023
relative pr: Fix replace SparkSQL function facebookincubator#277 Support kPreceeding & kFollowing for window range frame type facebookincubator#287 support timestamp hash facebookincubator#269 Spark sum can overflow facebookincubator#101 Support float & double types in pmod function facebookincubator#157 Implement datetime functions in velox/sparksql. facebookincubator#81 Fix type check in MapFunction facebookincubator#273 Let function validation fail for lookaround pattern in RE2-based implementation facebookincubator#124 Register lpad/rpad functions for Spark SQL. facebookincubator#63 Support substring_index sql function facebookincubator#189 Fix First/Last aggregate functions intermediate type and support decimal facebookincubator#245 Support date_add spark sql function facebookincubator#144
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.