This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
Add hooks building to classification task (#62) #402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D19770583 |
aadcock
pushed a commit
to aadcock/ClassyVision-2
that referenced
this pull request
Apr 1, 2020
Summary: Pull Request resolved: facebookresearch#402 Pull Request resolved: fairinternal/ClassyVision#62 Add configurable hooks to classification task, had to remove the typehints from ClassyHook to avoid a circular dependency. Reviewed By: mannatsingh, vreis Differential Revision: D19770583 fbshipit-source-id: 0011c3519bf0af5c5e317319e80ede70127e754c
aadcock
force-pushed
the
export-D19770583
branch
from
60bdff0
to
1db8813
Compare
|
This pull request was exported from Phabricator. Differential Revision: D19770583 |
Summary: Pull Request resolved: facebookresearch#402 Pull Request resolved: fairinternal/ClassyVision#62 Add configurable hooks to classification task, had to remove the typehints from ClassyHook to avoid a circular dependency. As discussed, there are other options (for example importing in from_config), but since we keep running into this issue we are going to remove them to try and improve dev velocity. One more note, as requested I made the checkpoint hook a default option, but this led to some additional changes (need to allow input_args in checkpoint hook to be None as well as empty dict and had to add a make dir call in the task build). Differential Revision: D19770583 fbshipit-source-id: 15a3e6de204a7d89da7312c8a1dc58b085e4768e
aadcock
force-pushed
the
export-D19770583
branch
from
1db8813
to
351d727
Compare
|
This pull request was exported from Phabricator. Differential Revision: D19770583 |
|
This pull request has been merged in 3d1d277. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Pull Request resolved: https://github.com/fairinternal/ClassyVision/pull/62
Add configurable hooks to classification task, note this is not yet fully hooked up since code here: https://fburl.com/diffusion/ou4nszl2 sets the hooks (will fix this once I get feedback on the approach).
Differential Revision: D19770583