Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

Add hooks building to classification task (#62) #402

Closed
wants to merge 1 commit into from

Commits on Apr 2, 2020

  1. Add hooks building to classification task (facebookresearch#402)

    Summary:
    Pull Request resolved: facebookresearch#402
    
    Pull Request resolved: fairinternal/ClassyVision#62
    
    Add configurable hooks to classification task, had to remove the typehints from ClassyHook to avoid a circular dependency. As discussed, there are other options (for example importing in from_config), but since we keep running into this issue we are going to remove them to try and improve dev velocity.
    
    One more note, as requested I made the checkpoint hook a default option, but this led to some additional changes (need to allow input_args in checkpoint hook to be None as well as empty dict and had to add a make dir call in the task build).
    
    Differential Revision: D19770583
    
    fbshipit-source-id: 15a3e6de204a7d89da7312c8a1dc58b085e4768e
    Aaron Adcock authored and facebook-github-bot committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    351d727 View commit details
    Browse the repository at this point in the history