Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the build-time code out of compiler_gym package. #600

Closed
ChrisCummins opened this issue Mar 4, 2022 · 0 comments · Fixed by #620
Closed

Split the build-time code out of compiler_gym package. #600

ChrisCummins opened this issue Mar 4, 2022 · 0 comments · Fixed by #620
Assignees
Labels
Testing & Tooling Tests, tooling, and build systems

Comments

@ChrisCummins
Copy link
Contributor

ChrisCummins commented Mar 4, 2022

In bazel, build-time and package code can be mixed freely. For CMake, this build-time code needs to be split into a separate package to prevent headaches and workarounds such as:

# TODO(github.com/facebookresearch/CompilerGym/issues/506): Avoids circular
# dependency during specs.py generation, because it is imported from
# compiler_gym.envs.llvm before being generated.
sys.modules["compiler_gym.envs.llvm.is_making_specs"] = types.ModuleType(
"compiler_gym.envs.llvm.is_making_specs"
)

There are a couple of places that this needs updating, identified by TODO(github.com/facebookresearch/CompilerGym/issues/506).

This is related to #568.

@ChrisCummins ChrisCummins added the Testing & Tooling Tests, tooling, and build systems label Mar 4, 2022
ChrisCummins added a commit to ChrisCummins/CompilerGym that referenced this issue Mar 9, 2022
ChrisCummins added a commit to ChrisCummins/CompilerGym that referenced this issue Mar 10, 2022
ChrisCummins added a commit to ChrisCummins/CompilerGym that referenced this issue Mar 10, 2022
ChrisCummins added a commit to ChrisCummins/CompilerGym that referenced this issue Mar 10, 2022
ChrisCummins added a commit to ChrisCummins/CompilerGym that referenced this issue Mar 10, 2022
ChrisCummins added a commit to ChrisCummins/CompilerGym that referenced this issue Mar 10, 2022
ChrisCummins added a commit to ChrisCummins/CompilerGym that referenced this issue Mar 10, 2022
ChrisCummins added a commit to ChrisCummins/CompilerGym that referenced this issue Mar 10, 2022
ChrisCummins added a commit to ChrisCummins/CompilerGym that referenced this issue Mar 10, 2022
ChrisCummins added a commit to ChrisCummins/CompilerGym that referenced this issue Mar 10, 2022
ChrisCummins added a commit to ChrisCummins/CompilerGym that referenced this issue Mar 10, 2022
ChrisCummins added a commit to ChrisCummins/CompilerGym that referenced this issue Mar 10, 2022
ChrisCummins added a commit to ChrisCummins/CompilerGym that referenced this issue Mar 10, 2022
ChrisCummins added a commit to ChrisCummins/CompilerGym that referenced this issue Mar 10, 2022
ChrisCummins added a commit to ChrisCummins/CompilerGym that referenced this issue Mar 10, 2022
@ChrisCummins ChrisCummins self-assigned this Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing & Tooling Tests, tooling, and build systems
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant