-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split the build-time code out of compiler_gym package. #600
Labels
Testing & Tooling
Tests, tooling, and build systems
Comments
ChrisCummins
added a commit
to ChrisCummins/CompilerGym
that referenced
this issue
Mar 9, 2022
ChrisCummins
added a commit
to ChrisCummins/CompilerGym
that referenced
this issue
Mar 10, 2022
ChrisCummins
added a commit
to ChrisCummins/CompilerGym
that referenced
this issue
Mar 10, 2022
This was removed in facebookresearch#600.
ChrisCummins
added a commit
to ChrisCummins/CompilerGym
that referenced
this issue
Mar 10, 2022
ChrisCummins
added a commit
to ChrisCummins/CompilerGym
that referenced
this issue
Mar 10, 2022
Merging PR facebookresearch#600 set the cmake build on fire.
ChrisCummins
added a commit
to ChrisCummins/CompilerGym
that referenced
this issue
Mar 10, 2022
ChrisCummins
added a commit
to ChrisCummins/CompilerGym
that referenced
this issue
Mar 10, 2022
This was removed in facebookresearch#600.
ChrisCummins
added a commit
to ChrisCummins/CompilerGym
that referenced
this issue
Mar 10, 2022
ChrisCummins
added a commit
to ChrisCummins/CompilerGym
that referenced
this issue
Mar 10, 2022
Merging PR facebookresearch#600 set the cmake build on fire.
ChrisCummins
added a commit
to ChrisCummins/CompilerGym
that referenced
this issue
Mar 10, 2022
This was removed in facebookresearch#600.
ChrisCummins
added a commit
to ChrisCummins/CompilerGym
that referenced
this issue
Mar 10, 2022
ChrisCummins
added a commit
to ChrisCummins/CompilerGym
that referenced
this issue
Mar 10, 2022
Merging PR facebookresearch#600 set the cmake build on fire.
ChrisCummins
added a commit
to ChrisCummins/CompilerGym
that referenced
this issue
Mar 10, 2022
This was removed in facebookresearch#600.
ChrisCummins
added a commit
to ChrisCummins/CompilerGym
that referenced
this issue
Mar 10, 2022
ChrisCummins
added a commit
to ChrisCummins/CompilerGym
that referenced
this issue
Mar 10, 2022
Merging PR facebookresearch#600 set the cmake build on fire.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In bazel, build-time and package code can be mixed freely. For CMake, this build-time code needs to be split into a separate package to prevent headaches and workarounds such as:
CompilerGym/compiler_gym/envs/llvm/make_specs.py
Lines 17 to 22 in f8a5117
There are a couple of places that this needs updating, identified by
TODO(github.com/facebookresearch/CompilerGym/issues/506)
.This is related to #568.
The text was updated successfully, but these errors were encountered: