Remove build-time codegen using Python #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
ChrisCummins
force-pushed
the
feature/600-build-time-codegen
branch
from
2f70250 to
1989b07
Compare
ChrisCummins
force-pushed
the
feature/600-build-time-codegen
branch
from
67e08ab to
3c619ca
Compare
This was referenced Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In bazel, build-time and package code can be mixed freely. For CMake, this build-time code needs to be split into a separate package to prevent headaches and workarounds, such as those that @sogartar had to land for #498.
This PR does a couple of things:
/build_tools, removing it from thecompiler_gymnamespace./build_toolsscripts at build time.The reason I chose to make the above change is that the build-time code that is generated changes only when the version of LLVM that CompilerGym is built against changes, and currently we only support a single version of LLVM. When adapting the code to different versions of LLVM, it is actually easier to hack on the generated code. We may need to revisit this when we progress on #568.
Fixes #600.