-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice job diana! one thing that I think is missing here is the ability to pass opts to the partner model if they differ from the primary model. one solution is to pass opt via a file. what do you think of this @stephenroller
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job diana! i have a few small requested changes below and then this will be ready to merge! 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just realized something and updated my comments
Your PR contains a change to a task. Please paste the results of the following command into a comment: python tests/datatests/test_new_tasks.py |
dad8e3d
to
1af5b9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple really tiny changes and then we're there!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for persisting through all of these iterations! looks great ⭐
Patch description
Allow self chat to be performed between two different models.
Testing steps
To self chat with two different models, add partner like so:
Self chat with same model, remains the same:
Logs