This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Make it easier to create an agent from model file. Before, we did not add a
datapath
ormodel_subargs
which could make loading or overriding opts difficult. Also cleaned up thecreate_agent_from_opt_file
function (renaming a few things and moving some stuff around). It's still a bit of a mess though TBH.Now you can do something like:
agent = create_agent_from_model_file('zoo:blender/blender_90M/model', {'inference': 'topk'})
and it will automatically create the agent with all of the correct arguments added and override the inference to topk.This will be useful for M-Turk and other tasks where we have to create "subagents" (like retrieve and refine). It is also incidentally useful for #2803 in which @dianaglzrico needs to create a
partner_agent
for two models to speak to each other.