Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Allow colored logging in jupyter notebooks. #3024

Merged
merged 4 commits into from
Aug 31, 2020
Merged

Conversation

stephenroller
Copy link
Contributor

@stephenroller stephenroller commented Aug 29, 2020

Patch description
Right now, jupyter/colab users see these full verbose logs that look like we're logging to files. It's quite annoying. This improves their experience.

Testing steps
image

@stephenroller stephenroller marked this pull request as ready for review August 30, 2020 00:52
@stephenroller
Copy link
Contributor Author

Lint is fixed in master

Copy link
Contributor

@EricMichaelSmith EricMichaelSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@stephenroller stephenroller merged commit e25270d into master Aug 31, 2020
@stephenroller stephenroller deleted the nicerpylab branch August 31, 2020 12:49
@stephenroller stephenroller mentioned this pull request Sep 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants