This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

refactor taskmaster2 to use tod metrics#3147

Closed

moyapchen wants to merge 25 commits intoslot_teachersfrom taskmaster2_metrics

+411-54

Commits on Oct 2, 2020

Add file for helper metrics for slots
Moya Chen
committed
Made linters happy; added a test case, cleaned up some defs
Moya Chen
committed
Move files + update file comment, as suggested
Moya Chen
committed
Manually run
Moya Chen
committed
Make sure tests are fine with moves
Moya Chen
committed
Add domain-specific jga
Moya Chen
committed
Fix spelling. Need to be better about running tests locally before pushing so all my mispellings don't go into the commit log...
Moya Chen
committed
fixes found while integrating into taskmaster2
Moya Chen
committed
Add flag for if to count empty teacher values
Moya Chen
committed
tesssssts
Moya Chen
committed
refactor taskmaster2 to use tod metrics
Moya Chen
committed
remove unused imports
Moya Chen
committed
address comments (get rid of separate class, add func to Metrics directly)
Moya Chen
committed
actually do the things the last comment
Moya Chen
committed
Add test for interactive_web (#3114 )

stephenroller
authored and
Moya Chen
committed
Allow missing args when using --init-opt (#3112 )

EricMichaelSmith
authored and
Moya Chen
committed
Add notion of metrics collections, which can have other Metrics of multiple metrics be added to it
Moya Chen
committed
address comments (get rid of separate class, add func to Metrics directly)
Moya Chen
committed
address comments, Tuple -> List cause the errors were bothering me. (addressing comments = adding comments + fixing grammar, mostly).
Moya Chen
committed
Add ability for Metrics to add metrics from another Metrics object (#3145 )

moyapchen
authored and
Moya Chen
committed
Add notion of metrics collections, which can have other Metrics of multiple metrics be added to it
Moya Chen
committed
Add ability for Metrics to add metrics from another Metrics object (#3145 )

moyapchen
authored and
Moya Chen
committed
address comments (get rid of separate class, add func to Metrics directly)
Moya Chen
committed
Add notion of metrics collections, which can have other Metrics of multiple metrics be added to it
Moya Chen
committed
figure out what's going on with rebase errors...
Moya Chen
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor taskmaster2 to use tod metrics#3147

Commits on Oct 2, 2020

Add file for helper metrics for slots

Made linters happy; added a test case, cleaned up some defs

Move files + update file comment, as suggested

Manually run

Make sure tests are fine with moves

Add domain-specific jga

Fix spelling. Need to be better about running tests locally before pushing so all my mispellings don't go into the commit log...

fixes found while integrating into taskmaster2

Add flag for if to count empty teacher values

tesssssts

refactor taskmaster2 to use tod metrics

remove unused imports

address comments (get rid of separate class, add func to Metrics directly)

actually do the things the last comment

Add test for interactive_web (#3114 )

Allow missing args when using `--init-opt` (#3112 )

Add notion of metrics collections, which can have other Metrics of multiple metrics be added to it

address comments (get rid of separate class, add func to Metrics directly)

address comments, Tuple -> List cause the errors were bothering me. (addressing comments = adding comments + fixing grammar, mostly).

Add ability for Metrics to add metrics from another Metrics object (#3145 )

Add notion of metrics collections, which can have other Metrics of multiple metrics be added to it

Add ability for Metrics to add metrics from another Metrics object (#3145 )

address comments (get rid of separate class, add func to Metrics directly)

Add notion of metrics collections, which can have other Metrics of multiple metrics be added to it

figure out what's going on with rebase errors...