This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
[tests] Make crowdsource tests whitespace-agnostic #3628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricMichaelSmith
approved these changes
Apr 28, 2021
| @@ -191,7 +191,7 @@ def _check_file_contents( | |||
| results_folder=results_folder, file_suffix=file_suffix | |||
| ) | |||
| with open(file_path) as f: | |||
| contents = f.read() | |||
| contents = f.read().rstrip('\n') + '\n' | |||
There was a problem hiding this comment.
Okay, this works - maybe there can be a comment saying why this is needed (i.e. to be insensitive to whitespace linting issues?)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
#3621 broke crowdsourcing tests by stripping a bunch of whitespace from our regression files. Annoying, but just correct for this in the test and strip the comparison point as well.
Testing steps
CI.