Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Handling the MTurkUnit with no message data #3629

Merged
merged 2 commits into from
Apr 29, 2021
Merged

Conversation

mojtaba-komeili
Copy link
Contributor

Patch description
After the recent changes to Mephisto, when I try to compile the data from the data collection task, there is the following error that indicates some of the MTurkUnits have no messages.

  File ".../Mephisto/mephisto/abstractions/blueprints/parlai_chat/parlai_chat_agent_state.py", line 99, in get_parsed_data
    if "WORLD_DATA" in messages[-1]:
IndexError: list index out of range

Testing steps
My data compiler ran without any issue after these changes. It just produced a couple of warnings that indicated the units with missing data.

@mojtaba-komeili
Copy link
Contributor Author

@JackUrb there might be something missing on the Mephisto side that might resolve this issue for the future. But I think it is good to have this for corrupted data in general.

@JackUrb
Copy link
Contributor

JackUrb commented Apr 28, 2021

Adding @EricMichaelSmith as this is now breaking crowdsourcing tests.

@EricMichaelSmith
Copy link
Contributor

@mojtaba-komeili Can you try pulling from master? Stephen recently merged in a PR at #3628 that should hopefully remedy the crowdsourcing test issues

@mojtaba-komeili
Copy link
Contributor Author

@mojtaba-komeili Can you try pulling from master? Stephen recently merged in a PR at #3628 that should hopefully remedy the crowdsourcing test issues

Yeah, that solved the issue. Thanks!

@mojtaba-komeili mojtaba-komeili merged commit 98bd3d6 into master Apr 29, 2021
@mojtaba-komeili mojtaba-komeili deleted the incomplete-data branch April 29, 2021 15:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants