This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Written explanation for why tilde key cannot be used for $HOME #3690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricMichaelSmith
approved these changes
Jun 7, 2021
| # TODO: allow ~ to be parsed correctly | ||
| # Currently Hydra overrides the tilde key at lower levels as described here: https://hydra.cc/docs/next/advanced/override_grammar/basic/#grammar | ||
| # Thus the TILDE key cannot be used in replacement for $HOME variable | ||
| # Some hacky solution can probably be achieved but won't be good code so for now this assert is written as a placeholder |
There was a problem hiding this comment.
Thanks for adding this comment! This line is a bit long - if you get a Lint error for this line, you might want to split this into 2 lines (./autoformat.sh might also fix this for you, not sure)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Added an informative message in comments for why the TILDE key cannot be used in mephisto.blueprint.chat_data_folder argument.
Testing steps
Just comments in this PR.
CircleCI tests ran successfully.
Other information