Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Written explanation for why tilde key cannot be used for $HOME #3690

Merged
merged 1 commit into from
Jun 7, 2021
Merged

Written explanation for why tilde key cannot be used for $HOME #3690

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion parlai/crowdsourcing/tasks/model_chat/model_chat_blueprint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,9 @@ def assert_task_args(
f'"~" can\'t currently be parsed in the chat data folder path '
f'{args.blueprint.chat_data_folder}'
)
# TODO: allow ~ to be parsed correctly
# Currently Hydra overrides the tilde key at lower levels as described here: https://hydra.cc/docs/next/advanced/override_grammar/basic/#grammar
# Thus the TILDE key cannot be used in replacement for $HOME variable
# Some hacky solution can probably be achieved but won't be good code so for now this assert is written as a placeholder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this comment! This line is a bit long - if you get a Lint error for this line, you might want to split this into 2 lines (./autoformat.sh might also fix this for you, not sure)


if args.blueprint.get("annotations_config_path", "") != "":
full_path = os.path.expanduser(args.blueprint.annotations_config_path)
Expand Down