This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
[T5] Fix HF versioning issue #4164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| HF_VERSION = float('.'.join(transformers.__version__.split('.')[:2])) | ||
| HF_VERSION = ( | ||
| int(transformers.__version__.split('.')[0]), | ||
| int(transformers.__version__.split('.')[1]), |
There was a problem hiding this comment.
nit (question): looking at their version history it looks like they only add letter like rc to the third digit. Is that always the case? Should we worry about int transformation here ever?
There was a problem hiding this comment.
i think we can worry about that later, if it becomes an issue. but good to know ahead of time
mojtaba-komeili
approved these changes
Nov 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Addresses issue #4148; now correctly check HF versioning
Testing steps
Locally tested that various versions worked; also CI for T5