Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

[T5] Fix HF versioning issue #4164

Merged
merged 1 commit into from
Nov 12, 2021
Merged

[T5] Fix HF versioning issue #4164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion parlai/agents/hugging_face/hugging_face.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,10 @@
raise ImportError('Please run `pip install transformers`.')


HF_VERSION = float('.'.join(transformers.__version__.split('.')[:2]))
HF_VERSION = (
int(transformers.__version__.split('.')[0]),
int(transformers.__version__.split('.')[1]),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit (question): looking at their version history it looks like they only add letter like rc to the third digit. Is that always the case? Should we worry about int transformation here ever?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we can worry about that later, if it becomes an issue. but good to know ahead of time

)


class HuggingFaceAgent:
Expand Down
10 changes: 9 additions & 1 deletion parlai/agents/hugging_face/t5.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,16 @@
from parlai.core.torch_generator_agent import TorchGeneratorAgent, TorchGeneratorModel


def check_hf_version(v: Tuple[int, int]) -> bool:
"""
Check that HF version is greater than 4.3
"""
main, sub = v
return main > 4 or (main == 4 and sub >= 3)


def build_t5(opt: Opt) -> T5ForConditionalGeneration:
if not HF_VERSION >= 4.3:
if not check_hf_version(HF_VERSION):
raise RuntimeError('Must use transformers package >= 4.3 to use t5')
return T5ForConditionalGeneration.from_pretrained(
opt['t5_model_arch'], dropout_rate=opt['t5_dropout']
Expand Down
5 changes: 2 additions & 3 deletions tests/nightly/gpu/test_t5.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,9 @@
try:
import transformers # noqa
from parlai.agents.hugging_face.hugging_face import HF_VERSION
from parlai.agents.hugging_face.t5 import TASK_CONFIGS
from parlai.agents.hugging_face.t5 import set_device
from parlai.agents.hugging_face.t5 import TASK_CONFIGS, check_hf_version, set_device

HF_AVAILABLE = HF_VERSION >= 4.3
HF_AVAILABLE = check_hf_version(HF_VERSION)
except ImportError:
TASK_CONFIGS = None
set_device = unittest.skip
Expand Down