This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[TOD][straightforward] Tod world output jsonl structure to teacher task #4180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See documentation block in `tod_agents.py`
As noted in the README, this agent takes data generated from `tod_world_script.py` and dumps it out to a teacher. (Note that I tried setting up a regression test for this teacher, but I ran into issues getting it to save the output directory to not be something that included my local homedir name in it..)
See documentation block in `tod_agents.py` (I'm not 100% sure if `conftest.py` is a right file to change, though I did notice that `pytest.ini` was necessary to get pytest to run.)
See documentation in `tod_world_script.py` for usage.
…iff in stack, but lost from this one
moyapchen
requested review from
stephenroller,
EricMichaelSmith,
chinnadhurai,
skiingpacman and
pooyanamini
November 16, 2021 20:36
…mplications for mutators too?)
stephenroller
approved these changes
Dec 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stamped
EricMichaelSmith
pushed a commit
that referenced
this pull request
Dec 22, 2021
EricMichaelSmith
added a commit
that referenced
this pull request
Dec 23, 2021
* Add flag for external DB * [WIP] Fix crowdsourcing CI check * [TOD] World, world metrics, script, tests (#4178) * [TOD][straightforward] Tod world output jsonl structure to teacher task (#4180) * [TOD][Dataset][Easy] Google SGD in TOD Conversations format (#4181) * Add flag for external DB * Try to fix unit test * Minor Co-authored-by: Moya Chen <72097364+moyapchen@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in the README, this agent takes data generated from
tod_world_script.py
and dumps it out to a teacher.(Note that I tried setting up a regression test for this teacher, but I ran into issues getting it to save the output directory to not be something that included my local homedir name in it..)