Skip to content
This repository was archived by the owner on Nov 3, 2023. It is now read-only.

Use external database in crowdsourcing code #4272

Merged
merged 11 commits into from
Dec 23, 2021
Merged

Use external database in crowdsourcing code #4272

merged 11 commits into from
Dec 23, 2021

Conversation

EricMichaelSmith
Copy link
Contributor

Patch description
Allow for specifying a non-default Mephisto database to read in crowdsourcing results from.

Testing steps
CI checks, as well as a test command of this form:

python ${PROJECT_FOLDER}/compile_results.py \
--task-name ${TASK_NAME} \
--output-folder ${OUTPUT_FOLDER} \
--database-path ${DB_PATH}

@EricMichaelSmith EricMichaelSmith changed the title Use external database in crowdsourcing code [WIP] Use external database in crowdsourcing code Dec 22, 2021
@EricMichaelSmith EricMichaelSmith marked this pull request as draft December 22, 2021 21:28
Base automatically changed from EricMichaelSmith-patch-1 to main December 22, 2021 21:41
@EricMichaelSmith EricMichaelSmith changed the title [WIP] Use external database in crowdsourcing code Use external database in crowdsourcing code Dec 22, 2021
@EricMichaelSmith EricMichaelSmith marked this pull request as ready for review December 22, 2021 22:37
mojtaba-komeili
mojtaba-komeili reviewed Dec 23, 2021
View reviewed changes
tests/crowdsourcing/test_analysis.py
DUMMY_OPT = {'task_name': 'mock_task_name', 'output_folder': '/dummy/tmp'}
parser_ = AbstractResultsCompiler.setup_args()
opt_string = '--task-name mock_task_name --output-folder /dummy/tmp'
args_ = parser_.parse_args(opt_string.split())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up here.

mojtaba-komeili
mojtaba-komeili approved these changes Dec 23, 2021
View reviewed changes
Copy link
Contributor

@mojtaba-komeili mojtaba-komeili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@EricMichaelSmith EricMichaelSmith merged commit 339a29e into main Dec 23, 2021
@EricMichaelSmith EricMichaelSmith deleted the crowdsourcing-analysis-use-external-db branch December 23, 2021 18:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mojtaba-komeili mojtaba-komeili mojtaba-komeili approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EricMichaelSmith @mojtaba-komeili @facebook-github-bot @moyapchen