This repository was archived by the owner on Nov 3, 2023. It is now read-only.
[BB2] Handling increase in batch size from dynamic batching #4238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could you elaborate why there are "empty" doc scores? edit: nvm, think I understand. does this not mess up the scores computations down the road? |
Do we even use the empty ones even. I thought they were ignored. I don't really know much about how dynamic batching works. |
stephenroller
approved these changes
Dec 10, 2021
|
https://parl.ai/docs/tutorial_worlds.html see here for an explanation of dynamic batching |
Actually reading that helped me find the bug, but I am not sure if ignoring the empty batches is safe for BB2. |
mojtaba-komeili
added a commit
that referenced
this pull request
Dec 16, 2021
* ConversationTeacher parent class changed * reformat * [Crowdsourcing] can call blueprints from command line (#4254) * remove unnecessary run scripts * udpate readmes * BB2 handling increase in batch size during dynamic batching (#4238) * ConversationTeacher parent class changed * reformat * changed the teacher, tests are passing * removing 'episode_done' if it exists in the example Co-authored-by: Megan Ung <20617868+meganung@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Dynamic batching in ParlAI increases the batch size. This causes some issues with empty
doc_scoreplace-holders that BB2 uses: they don't get filled and remain empty, which results in run-time error during tensor operations. This patch filters the emptydoc_scoreplace-holders.