This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
ConversationTeacher parent class changed #4256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parlai/core/teachers.py
Outdated
| @@ -1611,12 +1611,12 @@ def setup_data(self, datafile): | |||
| yield act, next_episode_new | |||
|
|
|||
|
|
|||
| class ConversationTeacher(FixedDialogTeacher): | |||
| class ConversationTeacher(ParlAIDialogTeacher): | |||
There was a problem hiding this comment.
I think it might need to be DialogTeacher, not ParlAIDialogTeacher
There was a problem hiding this comment.
What makes DialogTeacher preferable to ParlAIDialogTeacher here?
There was a problem hiding this comment.
ParlAI DT should be assuming a particular format. It might be that we successfully override everything but really we shouldn't.
mojtaba-komeili
force-pushed
the
conv-teacher
branch
from
815ac82 to
22d21c7
Compare
* remove unnecessary run scripts * udpate readmes
…rlAI into conv-teacher * 'conv-teacher' of https://github.com/facebookresearch/ParlAI: reformat ConversationTeacher parent class changed
|
@stephenroller I changed the base class to |
stephenroller
approved these changes
Dec 16, 2021
| @@ -1719,27 +1704,24 @@ def _setup_data(self, path): | |||
| if self.label_turns in ['firstspeaker', 'both']: | |||
| eps = self._get_ep_from_turns(turns[::2], turns[1::2]) | |||
| if eps: | |||
| self.episodes.append(eps) | |||
| self.num_exs += len(eps) | |||
| for example, example_begins in self._return_episode_examples(eps): | |||
|
|
||
| # train on even turns as labels (turns w/ second speaker) | ||
| if self.label_turns in ['secondspeaker', 'both']: | ||
| eps = self._get_ep_from_turns(turns[1::2], turns[2::2]) | ||
| if eps: | ||
| self.episodes.append(eps) | ||
| self.num_exs += len(eps) | ||
| for example, example_begins in self._return_episode_examples(eps): |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Changed
ConversationTeacher's parent class toParlAIDialogTeacher.Testing steps
1- Standard teacher tests in ParlAI that rely on
ConversationTeacher.2-
parlai ddsome internal classes that use this teacher