Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

[circle] Fixing broken unit tests #4343

Merged
merged 45 commits into from
Mar 2, 2022
Merged

[circle] Fixing broken unit tests #4343

merged 45 commits into from
Mar 2, 2022

Conversation

stephenroller
Copy link
Contributor

@stephenroller stephenroller commented Feb 6, 2022

Patch description
Circle is broken for an unknown reason pretty much a dozen reasons.

Actions taken to get us to greens:

  • Bump python to 3.8. This causes a cascade of upgrades
  • Switch to the new GPU containers we were supposed to use a month ago. This causes a CUDA bump
  • Fix OS X tests by upgrading to newer versions of OS X.
  • Disable Zero 2. It's causing a hang for now. May need to bump that.
  • Fix a number of tests as a result of the above cascades.

Testing steps
CI

@stephenroller stephenroller marked this pull request as ready for review February 27, 2022 18:52
@stephenroller
Copy link
Contributor Author

Copy link
Contributor

@EricMichaelSmith EricMichaelSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, super great to have! No issues that I can see

Copy link
Contributor

@klshuster klshuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

description: Install torch GPU and dependencies
steps:
- run:
name: Install torch GPU and dependencies
command: |
python -m pip install --progress-bar off 'torch==1.8.1' 'torchvision~=0.9.0' 'torchtext~=0.9.0'
python -m pip install --progress-bar off 'fairscale~=0.3.0'
python -m pip install --progress-bar off torch==1.10.2+cu113 torchvision==0.11.3+cu113 torchaudio==0.10.2+cu113 -f https://download.pytorch.org/whl/cu113/torch_stable.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if cu113 means cuda 11.3 here, doesn't that conflict with the CUDA_VERSION "11.2" above?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried bumping it but this is the only combo that works.

.circleci/config.yml Outdated Show resolved Hide resolved
parlai/agents/transformer/transformer.py Show resolved Hide resolved
parlai/utils/fsdp.py Show resolved Hide resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants