Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

[fsdp] Bring back flatten parameters. #4403

Merged
merged 2 commits into from
Mar 15, 2022
Merged

[fsdp] Bring back flatten parameters. #4403

merged 2 commits into from
Mar 15, 2022

Conversation

stephenroller
Copy link
Contributor

Patch description
A recent patch (#4343) changed fairscale from using flatten parameters True to False. However, this seems broken in recent versions of fairscale. Several users (internal and external) have reported switching this back resolves a crash, so switching it back.

Testing steps
CI. User reports.

@stephenroller stephenroller requested a review from klshuster March 15, 2022 15:18
@stephenroller stephenroller merged commit 782d602 into main Mar 15, 2022
@stephenroller stephenroller deleted the zero2fsdp branch March 15, 2022 15:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants