-
Notifications
You must be signed in to change notification settings - Fork 2.1k
add emoji input functionality to model chat crowdsourcing task #4666
add emoji input functionality to model chat crowdsourcing task #4666
Conversation
Hmm - can you run |
Done. |
Hmm - I'm a bit nervous about changing the model chat task to always show the emoji picker, because many of our models can't handle emojis, and so this might mean that the future conversations that we collect will contain largely unparseable emojis. Could you try adding a Hydra flag to conditionally show the emoji picker and default it to False? Another issue is that it looks like this change means that developers will always need to run |
See updated description above |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm - the one thing I'm still a bit worried about is that people will now have to install the emoji picker tool in order to use model chat, even if the emoji picker flag is False. But since we always have to install a bunch of packages anyway to run any task, I'm not convinced that one more will be a huge problem. Thus, I'm willing to go ahead and approve this - if this extra package becomes a huge problem, we can reassess later. Great addition!
Users can now add emojis to the text box by using the emoji picker. To show the emoji picker, you need to set the emoji_picker flag to true (it's set to false by default).
Test plan:
npm install react-input-emoji
python parlai/crowdsourcing/tasks/model_chat/run.py mephisto.blueprint.emoji_picker=true