Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Reverting emoji response patch in model chat #4934

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

mojtaba-komeili
Copy link
Contributor

Patch description

Revert "add emoji input functionality to model chat crowdsourcing task (#4666)"

This reverts commit 2f42a5b.

Ran into some issue running the the human-model chat. After consulting with @pringshia it was related to the changes in this PR. @meganung confirms that there is not going to be major side effects reverting this.

Copy link
Contributor

@meganung meganung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ! -- we can reimplement / refer back if this functionality is needed later down the line.

Copy link
Contributor

@EricMichaelSmith EricMichaelSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with Megan, seems fine to remove for now!

@mojtaba-komeili mojtaba-komeili merged commit cb369e9 into main Jan 19, 2023
@mojtaba-komeili mojtaba-komeili deleted the revert-react-emoji branch January 19, 2023 21:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants