Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Remove TGA._get_context() #4727

Merged
merged 2 commits into from
Aug 18, 2022
Merged

Remove TGA._get_context() #4727

merged 2 commits into from
Aug 18, 2022

Conversation

juderoque
Copy link
Contributor

Patch description

  • Deleted TGA._get_context() as it is not used anywhere and was replaced with TGA._get_batch_context()
  • Added warning incase users try to implement TGA._get_context()

@juderoque juderoque requested a review from emilydinan August 8, 2022 21:08
@juderoque juderoque marked this pull request as ready for review August 8, 2022 21:08
@juderoque juderoque changed the title Deprecate TGA._get_context() Remove TGA._get_context() Aug 8, 2022
@juderoque juderoque requested a review from klshuster August 8, 2022 21:44
klshuster
klshuster reviewed Aug 8, 2022
View reviewed changes
Copy link
Contributor

@klshuster klshuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is used in the RAG Agent?

does that mean that that function was never correctly being used?

@juderoque
Copy link
Contributor Author

I think this is used in the RAG Agent?

does that mean that that function was never correctly being used?

Yep seems that way.. seems that the function is never actually called even if one was to override it

@klshuster
Copy link
Contributor

I think this is used in the RAG Agent?
does that mean that that function was never correctly being used?

Yep seems that way.. seems that the function is never actually called even if one was to override it

Very interesting. I'm ok with this then

@klshuster klshuster merged commit 29ac940 into main Aug 18, 2022
@klshuster klshuster deleted the tga-deprecate-get-context branch August 18, 2022 13:53
@klshuster klshuster mentioned this pull request Aug 18, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@klshuster klshuster klshuster approved these changes

@emilydinan emilydinan Awaiting requested review from emilydinan

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juderoque @klshuster @facebook-github-bot