Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

[TGA] broken test #4754

Merged
merged 1 commit into from
Aug 19, 2022
Merged

[TGA] broken test #4754

merged 1 commit into from
Aug 19, 2022

Conversation

klshuster
Copy link
Contributor

Patch description
Looks like #4727 broke a few tests; this PR fixes

Testing steps
CI

spencerp
spencerp approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@spencerp spencerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

I'm assuming the broken teacher_tests are unrelated.

@klshuster
Copy link
Contributor Author

I'm assuming the broken teacher_tests are unrelated.

yep, i've got quite a slew of fix PRs

@klshuster klshuster merged commit 5b2fc1d into main Aug 19, 2022
@klshuster klshuster deleted the fix_tga_test branch August 19, 2022 14:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@spencerp spencerp spencerp approved these changes

@juderoque juderoque Awaiting requested review from juderoque

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@klshuster @spencerp @facebook-github-bot