Support Moduleted Deform Conv on CPU via torchvision #4938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Support for modulated deform conv in torchvision exists since v0.9.0 - use that just like we do for regular deform conv. Signed-off-by: Ievgen Popovych <jmennius@gmail.com>
…PU and CPU Reorganized forward tests to execute on both GPU and CPU for both variants of deformable conv. Compare modulated deformable conv between CPU and GPU as well. Also, let other tests run on CPU instead of limiting them to GPU machines. Signed-off-by: Ievgen Popovych <jmennius@gmail.com>
Jmennius
force-pushed
the
moduleted-deform-conv-cpu-via-torchvision
branch
from
11805fa to
738cce0
Compare
Author
|
Builds fail due to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like #2258 but for modulated deformable convolutions - let
torchvisiondo the heavylifting.Support for modulated deform conv in
torchvisionexists sincev0.9.0, so it doesn't seem to influence dependency requirements at the moment.Updated tests to let most of them run on CPU and extended other tests to cover modulated variant as well.