CI: Pin protobuf to latest 3.20 release #4939
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
PyTorch ships proto files which are incompatible with protobuf >=4 but there is no dependency version specification limiting that. For it doesn't seem that pytorch intends to support 4.* python protobuf (see pytorch/pytorch#78362, as well as protobuf versions are pinned in CI). Signed-off-by: Ievgen Popovych <jmennius@gmail.com>
Jmennius
force-pushed
the
pin-protobuf-in-ci-to-last-3.20-release
branch
from
90c2f36 to
cedf427
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyTorchships proto files which are incompatible withprotobuf >=4but there is no dependency version specification limiting that.For it doesn't seem that
pytorchintends to support4.*pythonprotobuf(see pytorch/pytorch#78362, as well as protobuf versions are pinned in CI).NOTE: this is only required for
pytorch <2.1. Pytorch since 2.1 seems to support newer protobuf.Previously,
TensorBoardhad a version specifier limitingprotobufversion for this specific reason, but with tensorflow/tensorboard#6147 merged (released with2.12.0) - it supports protobuf4.*and version specifier is relaxed to include4.*.Fixes: #4945