Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HiTL dashboard dataset visualization #1282

Open
wants to merge 54 commits into
base: main
Choose a base branch
from
Open

HiTL dashboard dataset visualization #1282

wants to merge 54 commits into from

Conversation

mialsy
Copy link
Contributor

@mialsy mialsy commented Jul 13, 2022

Description

New feature for Hitl dashboard: Added dataset visualization component including:
- View newly added data points indices on the run detail page
- View a specific version of dataset on dataset detail page

Type of change

Please check the options that are relevant.

  • Bug fix (non-breaking change that fixes an issue)
  • Proposes a change (non-breaking change that isn't necessarily a bug)
  • Refactor
  • New feature (non-breaking change that adds a new functionality)
  • Breaking change (fix or feature that would break some existing functionality downstream)
  • This is a unit test
  • Documentation only change
  • Datasets Release
  • Models Release

Type of requested review

  • I want a thorough review of the implementation.
  • I want a high level review.
  • I want a deep design review.

Before and After

  • Demo:
    • For job with retrain job, the user will be able to see the indices of newly added data
      • demo_dataset_has_retrain
    • For job without retrain job, the indices field will be NA
      • demo_dataset_no_retrain
    • Viewing different version of the dataset (use dropdown menu to select, able to serach in dropdown menu)
      • demo_change_dataset_ver
    • Flow for using the navigation tab to view a dataset
      • demo_navigate_from_tab

Testing

Manually tested

Checklist:

  • I have performed manual end-to-end testing of the feature in my environment.
  • I have added Docstrings and comments to the code.
  • I have made changes to existing documentation where needed.
  • I have added tests that show that the PR is functional.
  • New and existing unit tests pass locally with my changes.
  • I have added relevant collaborators to review the PR before merge.
  • [Polymetis only] I ran on hardware (1) all scripts in tests/scripts, (2) asv benchmarks.

mialsy and others added 30 commits June 22, 2022 22:35
@mialsy
add dashboard server backbone
bf6acbd
Automatic style fix for droidlet
0ed1b0c
@mialsy
add a get job list method
fbfa880
Automatic style fix for droidlet
281e040
@mialsy
ad impl for server to get log and get job info
ef2a89b
Automatic style fix for droidlet
fb17cd9
@mialsy
add test for aws helper, fix problem for setting json
8cc28ce
@mialsy
Merge branch 'hitl_dashboard_server' of https://github.com/facebookre…
a812c69 
…search/fairo into hitl_dashboard_server
Automatic style fix for droidlet
3e6e436
@mialsy
add documentation
b76060d
@mialsy
merge conflicts
43fab27
Automatic style fix for droidlet
bc6fcd5
@mialsy
Add demo gif
66e59fa
@mialsy
Update README.MD
afe9e85
@mialsy
added a navigation bar
837218a
@mialsy
removed debug console log
9cc7ccc
@mialsy
add backbone for pipeline metainfo and detail
2d0ee2c
@mialsy
added list view skeleton, TODO: backend interaction
0a5e22e
@mialsy
add a status column
613647d
@mialsy
updated panel to re-usable
0ab6081
@mialsy
add date columns
ec7d14d
@mialsy
update naming, detail page, and the documentation
e33f540
@mialsy
added a basic layout for run detail page
61b4b06
@mialsy
add more navigation
bee2ddd
@mialsy
add info display
fae8fcb
@mialsy
add more impl for get job detail
4fa640e
Automatic style fix for droidlet
4096d0e
@mialsy
fixed bugs
f0ac860
@mialsy
Merge branch 'hitl_dashboard_detail_run' of https://github.com/facebo…
22b3fa2 
…okresearch/fairo into hitl_dashboard_detail_run
@mialsy
add error handling
1de5842
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 13, 2022
@mialsy mialsy force-pushed the hitl_dashboard_detail_run branch from bed4a8a to 5154d40 Compare July 13, 2022 23:22
@mialsy mialsy requested a review from snyxan July 19, 2022 01:37
@mialsy mialsy changed the base branch from hitl_dashboard_detail_run to main August 15, 2022 21:46
@mialsy mialsy changed the base branch from main to hitl_dashboard_detail_run August 15, 2022 21:48
@mialsy mialsy changed the base branch from hitl_dashboard_detail_run to main August 15, 2022 22:07
@mialsy mialsy requested a review from snyxan August 15, 2022 22:07
@mialsy
Copy link
Contributor Author

mialsy commented Aug 15, 2022

Hi @snyxan saw your approval on this branch but since the previous base for this PR has been merged into main, so I want to merge the hitl_dashboard_dataset_viz into main now, may I ask you to take a quick look on the new pr again?

@mialsy
Hitl dashboard Dataset Page - pretty print json (#1317)
86615e8 
* update dataset to be showing pretty json onclick

* updated documentation

* Added demo img
@facebook-github-bot
Copy link

Hi @mialsy!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavyasrinet kavyasrinet Awaiting requested review from kavyasrinet

@aszlam aszlam Awaiting requested review from aszlam

@ethan-carlson ethan-carlson Awaiting requested review from ethan-carlson

@snyxan snyxan Awaiting requested review from snyxan

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mialsy @facebook-github-bot @snyxan