Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "make the ROS odometry (yaw) consistent with non-ROS" #1370

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

soumith
Copy link
Member

@soumith soumith commented Sep 11, 2022

This reverts commit 962db84.

This commit was buggy in deep ways

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2022

Codecov Report

Merging #1370 (ffae3ff) into main (3308290) will increase coverage by 19.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1370       +/-   ##
===========================================
+ Coverage   15.44%   34.45%   +19.01%     
===========================================
  Files         349      358        +9     
  Lines       34777    35455      +678     
===========================================
+ Hits         5372    12217     +6845     
+ Misses      29405    23238     -6167     
Impacted Files Coverage Δ
tests/test_base_utils.py 98.55% <0.00%> (ø)
tools/hitl/utils/tests/hitl_logging_test.py 98.07% <0.00%> (ø)
agents/droidlet_agent.py 51.73% <0.00%> (ø)
...hitl/dashboard_app/backend/dashboard_aws_helper.py 57.57% <0.00%> (ø)
...itl/dashboard_app/backend/dashboard_model_utils.py 44.44% <0.00%> (ø)
tools/hitl/utils/hitl_logging.py 100.00% <0.00%> (ø)
test_utils.py 21.87% <0.00%> (ø)
tools/hitl/utils/hitl_utils.py 21.21% <0.00%> (ø)
...ard_app/backend/tests/dashboard_aws_helper_test.py 98.00% <0.00%> (ø)
dialog/post_process_logical_form.py 29.23% <0.00%> (+1.53%) ⬆️
... and 126 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants