Removing flaky by running the test only on RGB (#1134)

* Removing flaky by running the test only on RGB
Testing RGB gets 1.0 values too often which makes the test fail regularly.
The same functionality is achieved by running only RGB in this test.

* wrong condition fix

---------

Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com>

.circleci/config.yml

@@ -146,6 +146,7 @@ jobs:
                 conda create -y -n habitat python=3.7
                 . activate habitat
                 pip install -U pip
+
                 conda install -q -y -c conda-forge ninja ccache numpy
                 pip install pytest-sugar>=0.9.6 mock cython pygame flaky pytest pytest-mock pytest-cov psutil
               fi

test/test_sensors.py

@@ -350,7 +350,6 @@ def test_imagegoal_sensor():
             )
 
 
-@pytest.mark.flaky(max_runs=3, min_passes=1)
 def test_get_observations_at():
     config = get_test_config()
     if not os.path.exists(config.habitat.simulator.scene):
@@ -393,9 +392,14 @@ def test_get_observations_at():
             new_obs = env.step(sample_non_stop_action(env.action_space))
             for key, val in new_obs.items():
                 agent_state = env.sim.get_agent_state()
-                if not (
-                    np.allclose(agent_state.position, start_state.position)
-                    and np.allclose(agent_state.rotation, start_state.rotation)
+                if (
+                    not (
+                        np.allclose(agent_state.position, start_state.position)
+                        and np.allclose(
+                            agent_state.rotation, start_state.rotation
+                        )
+                    )
+                    and "rgb" in key
                 ):
                     assert not np.allclose(val, obs[key])
             obs_at_point = env.sim.get_observations_at(