[update to #992] Fix and refactor MoveObjectReward #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
ASzot
approved these changes
Nov 21, 2022
vincentpierre
commented
Nov 21, 2022
Comment on lines
+163
to
+164
| if place_success and not is_holding_obj: | ||
| self._metric += self._config.single_rearrange_reward |
There was a problem hiding this comment.
@SergioArnaud Is it possible to double count the place reward here if the task does not end after placing? I would add a if self._cur_rearrange_stage < self.num_targets to make sure of it.
There was a problem hiding this comment.
@vincentpierre I think that case is considered in this condition. If all the objects are placed in the right place but for some reason we haven't succeded in the task (for example the agent hasn't called terminate) we give zero reward.
There was a problem hiding this comment.
Oh, nice. sorry I missed it.
7 tasks
dannymcy
pushed a commit
to dannymcy/habitat-lab
that referenced
this pull request
Jul 8, 2024
…acebookresearch#1010) * Fix and refactor MoveObjectReward * Fix and refactor MoveObjectReward - format * Fix and refactor MoveObjectReward - fix typo Co-authored-by: SergioArnaud <sercharnaud@gmail.com> Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com>
HHYHRHY
pushed a commit
to SgtVincent/EMOS
that referenced
this pull request
Aug 31, 2024
…acebookresearch#1010) * Fix and refactor MoveObjectReward * Fix and refactor MoveObjectReward - format * Fix and refactor MoveObjectReward - fix typo Co-authored-by: SergioArnaud <sercharnaud@gmail.com> Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
How Has This Been Tested
Types of changes
Checklist