[v0.2.3] Fixing mypy #1023
Merged
[v0.2.3] Fixing mypy #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Skylion007
reviewed
Nov 30, 2022
test/test_baseline_trainers.py
Outdated
| @@ -401,7 +401,7 @@ def pause_at(self, idx): | |||
|
|
|||
| expected = sorted(set(range(num_envs)) - set(envs_to_pause)) | |||
|
|
|||
| assert envs._running == expected | |||
| assert envs._running == expected # type:ignore | |||
There was a problem hiding this comment.
Can this be a qualified type ignore? ie. # type:ignore[ignore_reason] instead of a blanket one?
Skylion007
reviewed
Dec 1, 2022
docs/conf.py
Outdated
| @@ -24,7 +24,7 @@ | |||
| # Overrides the __all__ as that one pulls everything into the root module | |||
| # and doesn't expose any submodules | |||
| habitat.__all__ = ["config", "core", "Agent", "Benchmark"] | |||
| habitat.core.__all__ = [ # type:ignore | |||
| habitat.core.__all__ = [ # type: ignore[attr-defined] | |||
There was a problem hiding this comment.
We should probably just add docs/conf.py to the exclude regex as well.
|
Just need to install this missing types for CircleCI python-lint and we should be good. |
Or remove python_lint ? What does it do that pre-commit doesn't ? |
Allow for testing of dependencies in requirements.txt in case there is some issue in types-* vs mypy pre-commit hook. |
Skylion007
approved these changes
Dec 1, 2022
Skylion007
reviewed
Dec 1, 2022
Skylion007
reviewed
Dec 1, 2022
Skylion007
reviewed
Dec 1, 2022
Comment on lines
11
to
+12
| if TYPE_CHECKING: | ||
| from omegaconf import DictConfig | ||
| from omegaconf import Container |
There was a problem hiding this comment.
Needs to be out of the if TYPE_CHECKING or else it will cause errors in pytest. Or Container needs to be a string
Skylion007
reviewed
Dec 1, 2022
| @@ -50,7 +61,7 @@ def __init__( | |||
| """ | |||
| self.config = config.habitat | |||
| self.env = env | |||
| self.episodes = self.env._dataset.episodes # type:ignore | |||
| self.episodes: List[NavigationEpisode] = self.env._dataset.episodes | |||
There was a problem hiding this comment.
This might need to be a string too to avoid errors? Or at least "Navigation episode should be?" Or once again NavigationEpisode should be removed from if TYPE_CHECKING.
Suggested change
| self.episodes: List[NavigationEpisode] = self.env._dataset.episodes | |
| self.episodes: List["NavigationEpisode"] = self.env._dataset.episodes |
There was a problem hiding this comment.
@vincentpierre Was this part of the code checked? I am not sure it's covered by tests and I worry it could error on non-typechecking runtime?
There was a problem hiding this comment.
Sorry I don't understand. I did not add any unit tests for il in this PR. Why do you think it might break ?
There was a problem hiding this comment.
Because NavigationEpisode is not imported if not TYPE_CHECKING so the interpreter will break when it gets to that line, no?
There was a problem hiding this comment.
Even if it is in quotes?
There was a problem hiding this comment.
python -c "from habitat_baselines.il.data.nav_data import NavDataset
class A:
habitat = 1
class B:
episodes = 2
class C:
_dataset = B()
n = NavDataset(A(),C(),3)
"
Breaks line 67 instead of 53, so I guess there is no issue.
There was a problem hiding this comment.
Even if it is in quotes?
Missed that it was in quotes. Well if it didn't break anything obvious then it should be fine.
Skylion007
approved these changes
Dec 1, 2022
|
Thanks for doing this. Aside from some nits it looks good. |
Skylion007
reviewed
Dec 1, 2022
| @@ -28,6 +37,8 @@ | |||
| if TYPE_CHECKING: | |||
There was a problem hiding this comment.
In general, TYPE_CHECKING should be used sparingly and to avoid circular dependencies or occasionally heavy imports.
ASzot
pushed a commit
that referenced
this pull request
Dec 3, 2022
* [v0.2.3] Add robot document (#1018) * [v0.2.3] [Stretch] play stretch demo (#1014) * [Fix] Documentation gym example path (#1016) Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com> * [0.2.3]Hydra migration 3 v2 (#1000) * updated md files * updated habitat2_gym_tutorial * updated Habitat2_Quickstart * updated Habitat_Lab * updated docs * partially removed YACS (note there are some inpedendent parts of code that still rely on YACS) * made all DictConfig imports to be from omegaconf using if TYPE_CHECKING * removed link to the outdated notebook * fixed tests * [Hydra Migration] Removing yacs and migratting the dataset generation code of rearrange (#1001) * removing yacs and migratting the dataset generation code of rearrange * addressing comments * typechecking corrections Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com> * renaming SensorConfig to LabSensorConfig * fixing svg link * fixing svg; * using relative path is better for svg * addressed comments * [0.2.3][Hydra Migration] Made agents to be of type Dict[str, AgentConfig] and added migration readme (#1007) * made habitat.simulator.agents be a Dict[str, AgentConfig] * addressed comments * refactored sim agents configuration * moved rearrange agents declarations to agents folder; finised agents configuration updates; updated docs * updated get_config import * Cfg sys migration readme (#2) * added habitat-lab config readme * addressed most of the comments * added main_agent alias * renamed habitat config reagme and added baselines config readme * Update habitat-lab/habitat/config/default.py Co-authored-by: Vincent-Pierre BERGES <28320361+vincentpierre@users.noreply.github.com> * added desctiption for the agents_order field * added a dot :) Co-authored-by: Vincent-Pierre BERGES <28320361+vincentpierre@users.noreply.github.com> * fixing conflicts Co-authored-by: Vincent-Pierre BERGES <28320361+vincentpierre@users.noreply.github.com> Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com> * Fix links in MANIFEST.in (#991) * Fix broken links in MANIFEST.in * fixig video_render_view * fixing issue with gym maker * editing test that changed with recent config modifications * [v0.2.3] Fixing mypy (#1023) * Unpin habitat-lab requirements * Reorder dependencies * Fix mypy config * remove unnecessary mypy args * Update mypy version * Fix python lint * Fix pre-commit mypy further * fix mypy ignored errors * fixing mypy * fixing mypy * more accurate type:ignores * adding docs/ to exclude mypy * trying to fix python_lint * exlude arguments * exlude arguments * Container needs to be a string Co-authored-by: Aaron Gokaslan <aaronGokaslan@gmail.com> Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com> * removing the gym envs keys that were removed Co-authored-by: Jimmy Yang <55121504+jimmytyyang@users.noreply.github.com> Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com> Co-authored-by: Ruslan <partsey2412@gmail.com> Co-authored-by: Mikaël Dallaire Côté <110583667+0mdc@users.noreply.github.com> Co-authored-by: Aaron Gokaslan <aaronGokaslan@gmail.com>
ASzot
added a commit
that referenced
this pull request
Dec 7, 2022
* [bugfix] Reconfigure the sim even if the sim is not None * addressing comments, better way to decide wether or not to reconfigure sim_obj * same fix for the robot base * Added back caching to pick task * Fixed up nav to obj task * Fixed up open and close skills * Added back inits for nav to obj * Batched HRL policy * Updated task conditions * Fixed key mismatch in TP-SRL * Fixed issue with nav to obj skill * Fixed early stop issue * Fixed bad filter condition * Updated training configs * Refactored and cleaned up config files * Fixed up reward. Renamed configs * Added wandb resume * Refactored eval with debug sensor code. * Added get policy info * Hopefully fixed resuming, added safe drop * Added improved Fetch model * Removed refactored files * Added back default * Removed habitat folder * Fixed pick task * Fixed navigation skill * Removed redundancy in skill training configs * Addressed some comments * Removed nav pick * Update .gitignore Co-authored-by: Vincent-Pierre BERGES <28320361+vincentpierre@users.noreply.github.com> * PR comments * [v0.2.3] Hab2 fixup : merging main and resolving conflicts (#1022) * [v0.2.3] Add robot document (#1018) * [v0.2.3] [Stretch] play stretch demo (#1014) * [Fix] Documentation gym example path (#1016) Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com> * [0.2.3]Hydra migration 3 v2 (#1000) * updated md files * updated habitat2_gym_tutorial * updated Habitat2_Quickstart * updated Habitat_Lab * updated docs * partially removed YACS (note there are some inpedendent parts of code that still rely on YACS) * made all DictConfig imports to be from omegaconf using if TYPE_CHECKING * removed link to the outdated notebook * fixed tests * [Hydra Migration] Removing yacs and migratting the dataset generation code of rearrange (#1001) * removing yacs and migratting the dataset generation code of rearrange * addressing comments * typechecking corrections Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com> * renaming SensorConfig to LabSensorConfig * fixing svg link * fixing svg; * using relative path is better for svg * addressed comments * [0.2.3][Hydra Migration] Made agents to be of type Dict[str, AgentConfig] and added migration readme (#1007) * made habitat.simulator.agents be a Dict[str, AgentConfig] * addressed comments * refactored sim agents configuration * moved rearrange agents declarations to agents folder; finised agents configuration updates; updated docs * updated get_config import * Cfg sys migration readme (#2) * added habitat-lab config readme * addressed most of the comments * added main_agent alias * renamed habitat config reagme and added baselines config readme * Update habitat-lab/habitat/config/default.py Co-authored-by: Vincent-Pierre BERGES <28320361+vincentpierre@users.noreply.github.com> * added desctiption for the agents_order field * added a dot :) Co-authored-by: Vincent-Pierre BERGES <28320361+vincentpierre@users.noreply.github.com> * fixing conflicts Co-authored-by: Vincent-Pierre BERGES <28320361+vincentpierre@users.noreply.github.com> Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com> * Fix links in MANIFEST.in (#991) * Fix broken links in MANIFEST.in * fixig video_render_view * fixing issue with gym maker * editing test that changed with recent config modifications * [v0.2.3] Fixing mypy (#1023) * Unpin habitat-lab requirements * Reorder dependencies * Fix mypy config * remove unnecessary mypy args * Update mypy version * Fix python lint * Fix pre-commit mypy further * fix mypy ignored errors * fixing mypy * fixing mypy * more accurate type:ignores * adding docs/ to exclude mypy * trying to fix python_lint * exlude arguments * exlude arguments * Container needs to be a string Co-authored-by: Aaron Gokaslan <aaronGokaslan@gmail.com> Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com> * removing the gym envs keys that were removed Co-authored-by: Jimmy Yang <55121504+jimmytyyang@users.noreply.github.com> Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com> Co-authored-by: Ruslan <partsey2412@gmail.com> Co-authored-by: Mikaël Dallaire Côté <110583667+0mdc@users.noreply.github.com> Co-authored-by: Aaron Gokaslan <aaronGokaslan@gmail.com> * Merged * Removed bad file and fixed IK * Env fixes * Fixed precommit * Fixed eval and fixed wandb logging * Fix for the resume in VER and the force threshold for open tasks * Update habitat-baselines/habitat_baselines/rl/ddppo/policy/resnet_policy.py Co-authored-by: Aaron Gokaslan <skylion.aaron@gmail.com> * tp-srl fixes * tp-srl fixes * Fixed more tests * Cleaned up nav action * Added tests for all tasks in baseline trainer * Corrected test overrides * Improved agents loop in resnet_policy Improved agents loop in resnet_policy Co-authored-by: Ruslan <partsey2412@gmail.com> * Fixed policy docs and improvements. Added docs to spawn robot method. * [0.2.3] 959 PR review suggested changes (#1029) * removed habitat-baselines/habitat_baselines/config path prefix * improved adding render view uuids to the gym obs_keys * made config keys lowercase * Updated docs * Update habitat-lab/habitat/tasks/rearrange/rearrange_task.py Co-authored-by: Vincent-Pierre BERGES <28320361+vincentpierre@users.noreply.github.com> * Update habitat-baselines/habitat_baselines/rl/ddppo/policy/resnet_policy.py Co-authored-by: Aaron Gokaslan <skylion.aaron@gmail.com> * Fixed formatting * tp-srl config fix * fixing documentation ? Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com> Co-authored-by: ASzot <me@andrewszot.com> Co-authored-by: Vincent-Pierre BERGES <28320361+vincentpierre@users.noreply.github.com> Co-authored-by: Jimmy Yang <55121504+jimmytyyang@users.noreply.github.com> Co-authored-by: Ruslan <partsey2412@gmail.com> Co-authored-by: Mikaël Dallaire Côté <110583667+0mdc@users.noreply.github.com> Co-authored-by: Aaron Gokaslan <aaronGokaslan@gmail.com> Co-authored-by: Aaron Gokaslan <skylion.aaron@gmail.com> Co-authored-by: Oleksandr <maksymets.o@gmail.com> Co-authored-by: Oleksandr Maksymets <maksymets@gmail.com> Co-authored-by: SergioArnaud <sercharnaud@gmail.com>
dannymcy
pushed a commit
to dannymcy/habitat-lab
that referenced
this pull request
Jul 8, 2024
* Unpin habitat-lab requirements * Reorder dependencies * Fix mypy config * remove unnecessary mypy args * Update mypy version * Fix python lint * Fix pre-commit mypy further * fix mypy ignored errors * fixing mypy * fixing mypy * more accurate type:ignores * adding docs/ to exclude mypy * trying to fix python_lint * exlude arguments * exlude arguments * Container needs to be a string Co-authored-by: Aaron Gokaslan <aaronGokaslan@gmail.com> Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com>
dannymcy
pushed a commit
to dannymcy/habitat-lab
that referenced
this pull request
Jul 8, 2024
…okresearch#959) * [bugfix] Reconfigure the sim even if the sim is not None * addressing comments, better way to decide wether or not to reconfigure sim_obj * same fix for the robot base * Added back caching to pick task * Fixed up nav to obj task * Fixed up open and close skills * Added back inits for nav to obj * Batched HRL policy * Updated task conditions * Fixed key mismatch in TP-SRL * Fixed issue with nav to obj skill * Fixed early stop issue * Fixed bad filter condition * Updated training configs * Refactored and cleaned up config files * Fixed up reward. Renamed configs * Added wandb resume * Refactored eval with debug sensor code. * Added get policy info * Hopefully fixed resuming, added safe drop * Added improved Fetch model * Removed refactored files * Added back default * Removed habitat folder * Fixed pick task * Fixed navigation skill * Removed redundancy in skill training configs * Addressed some comments * Removed nav pick * Update .gitignore Co-authored-by: Vincent-Pierre BERGES <28320361+vincentpierre@users.noreply.github.com> * PR comments * [v0.2.3] Hab2 fixup : merging main and resolving conflicts (facebookresearch#1022) * [v0.2.3] Add robot document (facebookresearch#1018) * [v0.2.3] [Stretch] play stretch demo (facebookresearch#1014) * [Fix] Documentation gym example path (facebookresearch#1016) Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com> * [0.2.3]Hydra migration 3 v2 (facebookresearch#1000) * updated md files * updated habitat2_gym_tutorial * updated Habitat2_Quickstart * updated Habitat_Lab * updated docs * partially removed YACS (note there are some inpedendent parts of code that still rely on YACS) * made all DictConfig imports to be from omegaconf using if TYPE_CHECKING * removed link to the outdated notebook * fixed tests * [Hydra Migration] Removing yacs and migratting the dataset generation code of rearrange (facebookresearch#1001) * removing yacs and migratting the dataset generation code of rearrange * addressing comments * typechecking corrections Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com> * renaming SensorConfig to LabSensorConfig * fixing svg link * fixing svg; * using relative path is better for svg * addressed comments * [0.2.3][Hydra Migration] Made agents to be of type Dict[str, AgentConfig] and added migration readme (facebookresearch#1007) * made habitat.simulator.agents be a Dict[str, AgentConfig] * addressed comments * refactored sim agents configuration * moved rearrange agents declarations to agents folder; finised agents configuration updates; updated docs * updated get_config import * Cfg sys migration readme (facebookresearch#2) * added habitat-lab config readme * addressed most of the comments * added main_agent alias * renamed habitat config reagme and added baselines config readme * Update habitat-lab/habitat/config/default.py Co-authored-by: Vincent-Pierre BERGES <28320361+vincentpierre@users.noreply.github.com> * added desctiption for the agents_order field * added a dot :) Co-authored-by: Vincent-Pierre BERGES <28320361+vincentpierre@users.noreply.github.com> * fixing conflicts Co-authored-by: Vincent-Pierre BERGES <28320361+vincentpierre@users.noreply.github.com> Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com> * Fix links in MANIFEST.in (facebookresearch#991) * Fix broken links in MANIFEST.in * fixig video_render_view * fixing issue with gym maker * editing test that changed with recent config modifications * [v0.2.3] Fixing mypy (facebookresearch#1023) * Unpin habitat-lab requirements * Reorder dependencies * Fix mypy config * remove unnecessary mypy args * Update mypy version * Fix python lint * Fix pre-commit mypy further * fix mypy ignored errors * fixing mypy * fixing mypy * more accurate type:ignores * adding docs/ to exclude mypy * trying to fix python_lint * exlude arguments * exlude arguments * Container needs to be a string Co-authored-by: Aaron Gokaslan <aaronGokaslan@gmail.com> Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com> * removing the gym envs keys that were removed Co-authored-by: Jimmy Yang <55121504+jimmytyyang@users.noreply.github.com> Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com> Co-authored-by: Ruslan <partsey2412@gmail.com> Co-authored-by: Mikaël Dallaire Côté <110583667+0mdc@users.noreply.github.com> Co-authored-by: Aaron Gokaslan <aaronGokaslan@gmail.com> * Merged * Removed bad file and fixed IK * Env fixes * Fixed precommit * Fixed eval and fixed wandb logging * Fix for the resume in VER and the force threshold for open tasks * Update habitat-baselines/habitat_baselines/rl/ddppo/policy/resnet_policy.py Co-authored-by: Aaron Gokaslan <skylion.aaron@gmail.com> * tp-srl fixes * tp-srl fixes * Fixed more tests * Cleaned up nav action * Added tests for all tasks in baseline trainer * Corrected test overrides * Improved agents loop in resnet_policy Improved agents loop in resnet_policy Co-authored-by: Ruslan <partsey2412@gmail.com> * Fixed policy docs and improvements. Added docs to spawn robot method. * [0.2.3] 959 PR review suggested changes (facebookresearch#1029) * removed habitat-baselines/habitat_baselines/config path prefix * improved adding render view uuids to the gym obs_keys * made config keys lowercase * Updated docs * Update habitat-lab/habitat/tasks/rearrange/rearrange_task.py Co-authored-by: Vincent-Pierre BERGES <28320361+vincentpierre@users.noreply.github.com> * Update habitat-baselines/habitat_baselines/rl/ddppo/policy/resnet_policy.py Co-authored-by: Aaron Gokaslan <skylion.aaron@gmail.com> * Fixed formatting * tp-srl config fix * fixing documentation ? Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com> Co-authored-by: ASzot <me@andrewszot.com> Co-authored-by: Vincent-Pierre BERGES <28320361+vincentpierre@users.noreply.github.com> Co-authored-by: Jimmy Yang <55121504+jimmytyyang@users.noreply.github.com> Co-authored-by: Ruslan <partsey2412@gmail.com> Co-authored-by: Mikaël Dallaire Côté <110583667+0mdc@users.noreply.github.com> Co-authored-by: Aaron Gokaslan <aaronGokaslan@gmail.com> Co-authored-by: Aaron Gokaslan <skylion.aaron@gmail.com> Co-authored-by: Oleksandr <maksymets.o@gmail.com> Co-authored-by: Oleksandr Maksymets <maksymets@gmail.com> Co-authored-by: SergioArnaud <sercharnaud@gmail.com>
HHYHRHY
pushed a commit
to SgtVincent/EMOS
that referenced
this pull request
Aug 31, 2024
* Unpin habitat-lab requirements * Reorder dependencies * Fix mypy config * remove unnecessary mypy args * Update mypy version * Fix python lint * Fix pre-commit mypy further * fix mypy ignored errors * fixing mypy * fixing mypy * more accurate type:ignores * adding docs/ to exclude mypy * trying to fix python_lint * exlude arguments * exlude arguments * Container needs to be a string Co-authored-by: Aaron Gokaslan <aaronGokaslan@gmail.com> Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com>
HHYHRHY
pushed a commit
to SgtVincent/EMOS
that referenced
this pull request
Aug 31, 2024
…okresearch#959) * [bugfix] Reconfigure the sim even if the sim is not None * addressing comments, better way to decide wether or not to reconfigure sim_obj * same fix for the robot base * Added back caching to pick task * Fixed up nav to obj task * Fixed up open and close skills * Added back inits for nav to obj * Batched HRL policy * Updated task conditions * Fixed key mismatch in TP-SRL * Fixed issue with nav to obj skill * Fixed early stop issue * Fixed bad filter condition * Updated training configs * Refactored and cleaned up config files * Fixed up reward. Renamed configs * Added wandb resume * Refactored eval with debug sensor code. * Added get policy info * Hopefully fixed resuming, added safe drop * Added improved Fetch model * Removed refactored files * Added back default * Removed habitat folder * Fixed pick task * Fixed navigation skill * Removed redundancy in skill training configs * Addressed some comments * Removed nav pick * Update .gitignore Co-authored-by: Vincent-Pierre BERGES <28320361+vincentpierre@users.noreply.github.com> * PR comments * [v0.2.3] Hab2 fixup : merging main and resolving conflicts (facebookresearch#1022) * [v0.2.3] Add robot document (facebookresearch#1018) * [v0.2.3] [Stretch] play stretch demo (facebookresearch#1014) * [Fix] Documentation gym example path (facebookresearch#1016) Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com> * [0.2.3]Hydra migration 3 v2 (facebookresearch#1000) * updated md files * updated habitat2_gym_tutorial * updated Habitat2_Quickstart * updated Habitat_Lab * updated docs * partially removed YACS (note there are some inpedendent parts of code that still rely on YACS) * made all DictConfig imports to be from omegaconf using if TYPE_CHECKING * removed link to the outdated notebook * fixed tests * [Hydra Migration] Removing yacs and migratting the dataset generation code of rearrange (facebookresearch#1001) * removing yacs and migratting the dataset generation code of rearrange * addressing comments * typechecking corrections Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com> * renaming SensorConfig to LabSensorConfig * fixing svg link * fixing svg; * using relative path is better for svg * addressed comments * [0.2.3][Hydra Migration] Made agents to be of type Dict[str, AgentConfig] and added migration readme (facebookresearch#1007) * made habitat.simulator.agents be a Dict[str, AgentConfig] * addressed comments * refactored sim agents configuration * moved rearrange agents declarations to agents folder; finised agents configuration updates; updated docs * updated get_config import * Cfg sys migration readme (#2) * added habitat-lab config readme * addressed most of the comments * added main_agent alias * renamed habitat config reagme and added baselines config readme * Update habitat-lab/habitat/config/default.py Co-authored-by: Vincent-Pierre BERGES <28320361+vincentpierre@users.noreply.github.com> * added desctiption for the agents_order field * added a dot :) Co-authored-by: Vincent-Pierre BERGES <28320361+vincentpierre@users.noreply.github.com> * fixing conflicts Co-authored-by: Vincent-Pierre BERGES <28320361+vincentpierre@users.noreply.github.com> Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com> * Fix links in MANIFEST.in (facebookresearch#991) * Fix broken links in MANIFEST.in * fixig video_render_view * fixing issue with gym maker * editing test that changed with recent config modifications * [v0.2.3] Fixing mypy (facebookresearch#1023) * Unpin habitat-lab requirements * Reorder dependencies * Fix mypy config * remove unnecessary mypy args * Update mypy version * Fix python lint * Fix pre-commit mypy further * fix mypy ignored errors * fixing mypy * fixing mypy * more accurate type:ignores * adding docs/ to exclude mypy * trying to fix python_lint * exlude arguments * exlude arguments * Container needs to be a string Co-authored-by: Aaron Gokaslan <aaronGokaslan@gmail.com> Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com> * removing the gym envs keys that were removed Co-authored-by: Jimmy Yang <55121504+jimmytyyang@users.noreply.github.com> Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com> Co-authored-by: Ruslan <partsey2412@gmail.com> Co-authored-by: Mikaël Dallaire Côté <110583667+0mdc@users.noreply.github.com> Co-authored-by: Aaron Gokaslan <aaronGokaslan@gmail.com> * Merged * Removed bad file and fixed IK * Env fixes * Fixed precommit * Fixed eval and fixed wandb logging * Fix for the resume in VER and the force threshold for open tasks * Update habitat-baselines/habitat_baselines/rl/ddppo/policy/resnet_policy.py Co-authored-by: Aaron Gokaslan <skylion.aaron@gmail.com> * tp-srl fixes * tp-srl fixes * Fixed more tests * Cleaned up nav action * Added tests for all tasks in baseline trainer * Corrected test overrides * Improved agents loop in resnet_policy Improved agents loop in resnet_policy Co-authored-by: Ruslan <partsey2412@gmail.com> * Fixed policy docs and improvements. Added docs to spawn robot method. * [0.2.3] 959 PR review suggested changes (facebookresearch#1029) * removed habitat-baselines/habitat_baselines/config path prefix * improved adding render view uuids to the gym obs_keys * made config keys lowercase * Updated docs * Update habitat-lab/habitat/tasks/rearrange/rearrange_task.py Co-authored-by: Vincent-Pierre BERGES <28320361+vincentpierre@users.noreply.github.com> * Update habitat-baselines/habitat_baselines/rl/ddppo/policy/resnet_policy.py Co-authored-by: Aaron Gokaslan <skylion.aaron@gmail.com> * Fixed formatting * tp-srl config fix * fixing documentation ? Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com> Co-authored-by: ASzot <me@andrewszot.com> Co-authored-by: Vincent-Pierre BERGES <28320361+vincentpierre@users.noreply.github.com> Co-authored-by: Jimmy Yang <55121504+jimmytyyang@users.noreply.github.com> Co-authored-by: Ruslan <partsey2412@gmail.com> Co-authored-by: Mikaël Dallaire Côté <110583667+0mdc@users.noreply.github.com> Co-authored-by: Aaron Gokaslan <aaronGokaslan@gmail.com> Co-authored-by: Aaron Gokaslan <skylion.aaron@gmail.com> Co-authored-by: Oleksandr <maksymets.o@gmail.com> Co-authored-by: Oleksandr Maksymets <maksymets@gmail.com> Co-authored-by: SergioArnaud <sercharnaud@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
How Has This Been Tested
Types of changes
Checklist