Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing OMPL and SLAM #1075

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Removing OMPL and SLAM #1075

merged 1 commit into from
Jan 11, 2023

Conversation

vincentpierre
Copy link
Contributor

Motivation and Context

Deprecating OMPL and SLAM based methods in an effort to consolidate our codebase.

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@vincentpierre vincentpierre self-assigned this Jan 11, 2023
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 11, 2023
@dhruvbatra
Copy link
Contributor

Deleting 4k lines of code. Impacc 😄.

@vincentpierre vincentpierre merged commit fd0565f into facebookresearch:main Jan 11, 2023
This was referenced Jan 26, 2023
Merged
Closed
rpartsey added a commit that referenced this pull request Mar 10, 2023
@rpartsey
Update README.md (remove mentioning SLAM based)
afe5c81 
SLAM based baselines were removed in scope of #1075
@rpartsey rpartsey mentioned this pull request Mar 10, 2023
Merged
5 tasks
rpartsey added a commit that referenced this pull request Mar 13, 2023
@rpartsey
Update README.md (remove mentioning SLAM based) (#1193)
daac0b7 
SLAM based baselines were removed in scope of #1075
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@vincentpierre
removing OMPL and SLAM (facebookresearch#1075)
d56a2d2 
Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com>
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@rpartsey
Update README.md (remove mentioning SLAM based) (facebookresearch#1193)
4f803ac 
SLAM based baselines were removed in scope of facebookresearch#1075
HHYHRHY pushed a commit to SgtVincent/EMOS that referenced this pull request Aug 31, 2024
@vincentpierre
removing OMPL and SLAM (facebookresearch#1075)
3992629 
Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com>
HHYHRHY pushed a commit to SgtVincent/EMOS that referenced this pull request Aug 31, 2024
@rpartsey
Update README.md (remove mentioning SLAM based) (facebookresearch#1193)
4ade7ab 
SLAM based baselines were removed in scope of facebookresearch#1075
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

Assignees

@vincentpierre vincentpierre

Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vincentpierre @dhruvbatra @Skylion007 @facebook-github-bot