-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing gym registration to be faster #1144
Changing gym registration to be faster #1144
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Will people forget to add their new task to PRE_REGISTERED_GYM_TASKS? If a task lookup fails, can we print a pretty message with reminder to check PRE_REGISTERED_GYM_TASKS?
The lookup is managed by gym so it will be hard to have custom error messages on missing environments. I do not expect users to register their environments this way, I would prefer they used make_gym_env as documented in the README. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like these changes!
@vincentpierre do you mean |
Yes, exactly. |
Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com>
Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com>
Motivation and Context
Using gym.auto_name forces us to parse all files, load them and check the auto_name value. This is very slow. This change makes it such that the auto_gym environments are defined in a dictionary
PRE_REGISTERED_GYM_TASKS
in gym_definitions.pyHow Has This Been Tested
Types of changes
Checklist