-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Play spot #1177
Merged
Merged
Play spot #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Do not delete this pull request or issue due to inactivity.
label
Mar 2, 2023
ASzot
suggested changes
Mar 2, 2023
video play_spot_march2.mp4 |
ASzot
approved these changes
Mar 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Now the new Spot code is not affecting the existing code.
resolve conflict
dannymcy
pushed a commit
to dannymcy/habitat-lab
that referenced
this pull request
Jul 8, 2024
* mask the action space and get the spot yaml file * add offset and fix the leg movement * fix robot sim2real parameters, mostly camera parameters, action control resolve conflict * fix spot radius * make gripper open as a default init * a new action space using mask, and fix camera shaking issue resolve conflict * fix actions * use init to fix legs * fix rgb camera parameter and test robot wrapper * revert change * fix wrapper path * fix urdf * resolve merge conflict for the actions * fix merge issue v2
HHYHRHY
pushed a commit
to SgtVincent/EMOS
that referenced
this pull request
Aug 31, 2024
* mask the action space and get the spot yaml file * add offset and fix the leg movement * fix robot sim2real parameters, mostly camera parameters, action control resolve conflict * fix spot radius * make gripper open as a default init * a new action space using mask, and fix camera shaking issue resolve conflict * fix actions * use init to fix legs * fix rgb camera parameter and test robot wrapper * revert change * fix wrapper path * fix urdf * resolve merge conflict for the actions * fix merge issue v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Providing spot yaml file for Habitat 3.0, and users who want to test Spot in replica scene. It fixs(1) Calibrate Spot camera parameters to align them with the real camera parameters, including resolution, field of view
(2) Update Spot radius in yaml file to be consistent with the real robot
(3) Update
actions.py
to consider the base offset, and force the leg to stand still when moving.(4) Update
actions.py
to mask up certain control joints what are not in the real robot(4) Adjust Spot base offset parameters.
How Has This Been Tested
Both RGB and Depth images are aligned. The following is the image when the gripper is close.
Types of changes
Checklist