Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play spot #1177

Merged
merged 14 commits into from
Mar 3, 2023
Merged

Play spot #1177

merged 14 commits into from
Mar 3, 2023

Conversation

jimmytyyang
Copy link
Contributor

@jimmytyyang jimmytyyang commented Mar 2, 2023

Motivation and Context

Providing spot yaml file for Habitat 3.0, and users who want to test Spot in replica scene. It fixs

(1) Calibrate Spot camera parameters to align them with the real camera parameters, including resolution, field of view
(2) Update Spot radius in yaml file to be consistent with the real robot
(3) Update actions.py to consider the base offset, and force the leg to stand still when moving.
(4) Update actions.py to mask up certain control joints what are not in the real robot
(4) Adjust Spot base offset parameters.

How Has This Been Tested

Both RGB and Depth images are aligned. The following is the image when the gripper is close.
Screenshot 2023-03-02 at 11 33 34 AM
Screenshot 2023-03-02 at 11 33 49 AM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 2, 2023
@jimmytyyang
Copy link
Contributor Author

jimmytyyang commented Mar 2, 2023

Spot arm control parameters and the order
Screenshot 2023-03-02 at 1 59 11 PM

@jimmytyyang jimmytyyang requested a review from ASzot March 2, 2023 19:09
@jimmytyyang
Copy link
Contributor Author

video

play_spot_march2.mp4

Copy link
Contributor

@ASzot ASzot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Now the new Spot code is not affecting the existing code.

@jimmytyyang jimmytyyang merged commit 53b7a7a into main Mar 3, 2023
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
* mask the action space and get the spot yaml file

* add offset and fix the leg movement

* fix robot sim2real parameters, mostly camera parameters, action control
resolve conflict

* fix spot radius

* make gripper open as a default init

* a new action space using mask, and fix camera shaking issue
resolve conflict

* fix actions

* use init to fix legs

* fix rgb camera parameter and test robot wrapper

* revert change

* fix wrapper path

* fix urdf

* resolve merge conflict for the actions

* fix merge issue v2
HHYHRHY pushed a commit to SgtVincent/EMOS that referenced this pull request Aug 31, 2024
* mask the action space and get the spot yaml file

* add offset and fix the leg movement

* fix robot sim2real parameters, mostly camera parameters, action control
resolve conflict

* fix spot radius

* make gripper open as a default init

* a new action space using mask, and fix camera shaking issue
resolve conflict

* fix actions

* use init to fix legs

* fix rgb camera parameter and test robot wrapper

* revert change

* fix wrapper path

* fix urdf

* resolve merge conflict for the actions

* fix merge issue v2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants