Fixes for the HRL Trainer #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed interactive play * removing f string --------- Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com>
facebook-github-bot
added
the
CLA Signed
vincentpierre
approved these changes
Mar 23, 2023
habitat-lab/habitat/tasks/rearrange/multi_task/rearrange_pddl.py
Outdated
Show resolved
Hide resolved
Comment on lines
445
to
447
| island_radius = sim.pathfinder.island_radius(start_position) | ||
| if island_radius != targ_island_radius: | ||
| continue |
There was a problem hiding this comment.
Why we are checking this is not obvious.
Suggested change
| island_radius = sim.pathfinder.island_radius(start_position) | |
| if island_radius != targ_island_radius: | |
| continue | |
| island_radius = sim.pathfinder.island_radius(start_position) | |
| position_on_largest_island = island_radius == targ_island_radius | |
| if not position_on_largest_island: | |
| continue |
There was a problem hiding this comment.
Agreed, let me delay this change for a later PR to get the right solution.
vincentpierre
approved these changes
Mar 27, 2023
Merged
dannymcy
pushed a commit
to dannymcy/habitat-lab
that referenced
this pull request
Jul 8, 2024
* Speed fix * Added config overwrite * Updated speed fixes * Merged * Fixed PDDL * Bug Fix For Interactive Play Script (facebookresearch#1155) * Fixed interactive play * removing f string --------- Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com> * More PDDL fixes * Precommit * Updated docs * Cleaned up PDDL * Precommit * Fixed tests * Fixed PDDL base problem * Renamed PDDL types * CI test fix * PDDL Fixes * Handle repeat IDs * Fixed grasp criteria * Removed unnecessary code * Added rel idx fix * Proper rewards * Cleaned up sim * Removed unnecessary * Only PDDL for interactive play * Added some type check fixes * Addressing PR * Pddl fixes * precommit * Abstraction methods * Fixed problem with open/close tasks * Fixed tests --------- Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com>
HHYHRHY
pushed a commit
to SgtVincent/EMOS
that referenced
this pull request
Aug 31, 2024
* Speed fix * Added config overwrite * Updated speed fixes * Merged * Fixed PDDL * Bug Fix For Interactive Play Script (facebookresearch#1155) * Fixed interactive play * removing f string --------- Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com> * More PDDL fixes * Precommit * Updated docs * Cleaned up PDDL * Precommit * Fixed tests * Fixed PDDL base problem * Renamed PDDL types * CI test fix * PDDL Fixes * Handle repeat IDs * Fixed grasp criteria * Removed unnecessary code * Added rel idx fix * Proper rewards * Cleaned up sim * Removed unnecessary * Only PDDL for interactive play * Added some type check fixes * Addressing PR * Pddl fixes * precommit * Abstraction methods * Fixed problem with open/close tasks * Fixed tests --------- Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Bug fixes for the HRL trainer to properly work
How Has This Been Tested
Training the HL policy on the rearrange easy task.
Types of changes