Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.2.4] Finally fix pypi_deploy CI job 2 #1229

Merged
merged 1 commit into from
Mar 30, 2023
Merged

[0.2.4] Finally fix pypi_deploy CI job 2 #1229

merged 1 commit into from
Mar 30, 2023

Conversation

rpartsey
Copy link
Collaborator

  • added missing context
  • removed parameter substitution for repository parameter as it is not environmental variable

(tested job with SSH session this time pypi_deploy nightly should work as expected)

Motivation and Context

How Has This Been Tested

Types of changes

  • [Bug Fix] (non-breaking change which fixes an issue)

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@rpartsey rpartsey self-assigned this Mar 29, 2023
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 29, 2023
@vincentpierre vincentpierre changed the title Finally fix pypi_deploy CI job 2 [0.2.4] Finally fix pypi_deploy CI job 2 Mar 30, 2023
@rpartsey rpartsey merged commit 871518b into facebookresearch:main Mar 30, 2023
@rpartsey rpartsey deleted the packaging_and_pypi_distributing_fix3 branch April 8, 2023 06:50
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
HHYHRHY pushed a commit to SgtVincent/EMOS that referenced this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants