Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] - disable hab2 multi-proc benchmark assertions #1455

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Jul 17, 2023

Motivation and Context

Disabling CI regression assertions on multi-processing hab2 benchmark in light of recently observed flakyness.
Possible source of flakyness is resource limits. CI machine claims to have 8vCPU, we run a 16 process benchmark. This could cause thrashing or resource allocation issues.

This should be re-enabled after investigation and possible corrections to the CI benchmarking workflow.
We'll still run the multi-process benchmark and generate artifacts for debugging and investigation purposes.

How Has This Been Tested

CI shows benchmark regression with habitat-sim commit (facebookresearch/habitat-sim@8eb02ad).
Local testing on cluster shows no regression.
Contents of commit should not impact performance, so CI flakyness is likely.

Types of changes

  • [Docs change] Addition or changes to the documentation

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 17, 2023
@aclegg3 aclegg3 merged commit fd4148b into main Jul 17, 2023
@aclegg3 aclegg3 deleted the disable-multiproc-bench branch July 17, 2023 21:09
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
HHYHRHY pushed a commit to SgtVincent/EMOS that referenced this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants