Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hab3_merge] Add Skills for the robot to move forward/backward and turn #1508

Merged
merged 3 commits into from
Aug 23, 2023

Conversation

xavierpuigf
Copy link
Contributor

Motivation and Context

Add skills to allow low level movement for the robot. This is needed so that the robot can make way to the human when about to collide.

How Has This Been Tested

Tested with hl_fixed policy, verifying that the agent would turn when the skill is called.

Types of changes

  • [Experiment] A pull request that add new features to the habitat-baselines training codebase. Experiments Pull Requests can be any size, must have smoke/integration tests and be isolated from the rest of the code. Your code additions should not rely on other habitat-baselines code. This is to avoid dependencies between different parts of habitat-baselines. You must also include a README that will document how to use your new feature or trainer. You will be the maintainer of this code, if the code becomes stale or is not supported often enough, we will eventually remove it.

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@xavierpuigf xavierpuigf requested a review from ASzot August 17, 2023 18:48
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 17, 2023
@xavierpuigf xavierpuigf changed the title Add Skills for the robot to move forward/backward and turn [hab3_merge] Add Skills for the robot to move forward/backward and turn Aug 17, 2023
Copy link
Contributor

@ASzot ASzot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but if we are merging into main, we should have a test for this new skill.

@xavierpuigf
Copy link
Contributor Author

Thanks @ASzot ! I added pytests for the new skills

@xavierpuigf xavierpuigf merged commit f5b29e6 into main Aug 23, 2023
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
…rn (facebookresearch#1508)

* Add Skills to move forward/backward and turn

* update skills

* fix pytest
HHYHRHY pushed a commit to SgtVincent/EMOS that referenced this pull request Aug 31, 2024
…rn (facebookresearch#1508)

* Add Skills to move forward/backward and turn

* update skills

* fix pytest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants