-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spot Mobile Gaze Training Code #1647
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Do not delete this pull request or issue due to inactivity.
label
Oct 23, 2023
jimmytyyang
force-pushed
the
spot_mobile_gaze
branch
from
October 24, 2023 03:40
b34cb16
to
a05e808
Compare
ASzot
suggested changes
Oct 30, 2023
jimmytyyang
force-pushed
the
spot_mobile_gaze
branch
from
October 31, 2023 16:19
5d80be4
to
1082af5
Compare
Hi Andrew! It is nice to have you review this PR! I improved the readability of this PR. @ASzot |
ASzot
approved these changes
Nov 2, 2023
dannymcy
pushed a commit
to dannymcy/habitat-lab
that referenced
this pull request
Jul 8, 2024
* add spot head left and right sensors and clean up interactive_play function for spot * update the arm that can be controlled by users * clean up Spot's arm joint action space and make it more compact * make sure the gaze range is correct * update the bounding box * add yaml for pick * get the correct bounding box by ensuring the object index is correct * fix the issue that the target object id is a list, not being an integer * move angle computation function to util and update the pick reward for spot * add type * fix ci issue about config * fix CI * make the robot need not reset the arm after picking up the object * clean up auto grasp * make pick spot yaml uses kinematic mode * make it to be kinematic mode for action control * introduce collision count-based penality * update the reward function for the distance * parameter for the initialo cation of the robot * tyde CI * getting a corrcet init location of arm * tidy CI * adjust gaze skill init parameters * update the joint sensor of observation * add arm_depth_bbox_sensor * add stereo sensors * sensor clean up so that the size is the same * update SpotHeadStereoDepthSensor height and width * flip the right and left camera * fix None issue in the joint sensor * add constaint function * make the bounding box to be float32 data type * address Andrew's comment --------- Co-authored-by: Jimmy Yang <jimmytyyang@meta.com>
HHYHRHY
pushed a commit
to SgtVincent/EMOS
that referenced
this pull request
Aug 31, 2024
* add spot head left and right sensors and clean up interactive_play function for spot * update the arm that can be controlled by users * clean up Spot's arm joint action space and make it more compact * make sure the gaze range is correct * update the bounding box * add yaml for pick * get the correct bounding box by ensuring the object index is correct * fix the issue that the target object id is a list, not being an integer * move angle computation function to util and update the pick reward for spot * add type * fix ci issue about config * fix CI * make the robot need not reset the arm after picking up the object * clean up auto grasp * make pick spot yaml uses kinematic mode * make it to be kinematic mode for action control * introduce collision count-based penality * update the reward function for the distance * parameter for the initialo cation of the robot * tyde CI * getting a corrcet init location of arm * tidy CI * adjust gaze skill init parameters * update the joint sensor of observation * add arm_depth_bbox_sensor * add stereo sensors * sensor clean up so that the size is the same * update SpotHeadStereoDepthSensor height and width * flip the right and left camera * fix None issue in the joint sensor * add constaint function * make the bounding box to be float32 data type * address Andrew's comment --------- Co-authored-by: Jimmy Yang <jimmytyyang@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR ensures that Spot's simulation parameters are consistent with the ones in the real Spot. Several noticeable improvement includespython examples/interactive_play.py --never-end --disable-inverse-kinematics --cfg=benchmark/rearrange/play/play_spot.yaml
or you can use theyaml skills/pick_spot.yaml
interactive_play.py
runnable for Spotauto_grasp
function that is used for training real robot skillsExample:
arm RGB + depth sensor + semantic sensor + bounding box target + left/right cameras
How Has This Been Tested
Run `python examples/interactive_play.py --never-end --disable-inverse-kinematics --cfg=benchmark/rearrange/play/play_spot.yaml` and visually inspect the sensors.Types of changes
Checklist