-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exposed all existing documentation in Articulated_agents, articulated_agent_controllers, core, and config modules #1736
Merged
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
69da9ee
Update completed class/function documentation in labdocsv1
a02bbdd
Resolve Merge conflicts with origin/main
henrysamer 827c5ee
pre-commit passed
henrysamer 3fb5d09
Exposed class modules
henrysamer 7270c5d
Merge branch 'main' of https://github.com/facebookresearch/habitat-la…
henrysamer 713801d
Exposed methods in Articulated_agents, articulated_agent_controllers,…
henrysamer 20841f7
Merge remote-tracking branch 'origin/main' into labdocsv1
henrysamer 7bf341c
fix duplicate param causing doc build failure
aclegg3 b585959
Merge branch 'labdocsv1' of https://github.com/facebookresearch/habit…
henrysamer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,4 +20,6 @@ | |
"HumanoidBaseController", | ||
"HumanoidRearrangeController", | ||
"HumanoidSeqPoseController", | ||
"Pose", | ||
"Motion" | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,12 +18,9 @@ | |
@attr.s(auto_attribs=True, slots=True) | ||
class ArticulatedAgentCameraParams: | ||
"""Data to configure a camera placement on the articulated agent. | ||
:property attached_link_id: Which link ID this camera is attached to, -1 | ||
for the base link. | ||
:property cam_offset_pos: The 3D position of the camera relative to the | ||
transformation of the attached link. | ||
:property cam_look_at_pos: The 3D of where the camera should face relative | ||
to the transformation of the attached link. | ||
:property attached_link_id: Which link ID this camera is attached to, -1 for the base link. | ||
:property cam_offset_pos: The 3D position of the camera relative to the transformation of the attached link. | ||
:property cam_look_at_pos: The 3D of where the camera should face relative to the transformation of the attached link. | ||
:property relative_transform: An added local transform for the camera. | ||
""" | ||
|
||
|
@@ -41,32 +38,21 @@ class MobileManipulatorParams: | |
:property arm_joints: The joint ids of the arm joints. | ||
:property gripper_joints: The habitat sim joint ids of any grippers. | ||
:property wheel_joints: The joint ids of the wheels. If the wheels are not controlled, then this should be None | ||
:property arm_init_params: The starting joint angles of the arm. If None, | ||
resets to 0. | ||
:property gripper_init_params: The starting joint positions of the gripper. If None, | ||
resets to 0. | ||
:property ee_offset: The 3D offset from the end-effector link to the true | ||
end-effector position. | ||
:property arm_init_params: The starting joint angles of the arm. If None, resets to 0. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Wrapping the docstring like it was before shouldn't cause any problems for the doc generator. The successive lines just need to be indented respective to the first |
||
:property gripper_init_params: The starting joint positions of the gripper. If None, resets to 0. | ||
:property ee_offset: The 3D offset from the end-effector link to the true end-effector position. | ||
:property ee_links: A list with the Habitat Sim link ID of the end-effector. | ||
:property ee_constraint: A (ee_count, 2, N) shaped array specifying the upper and | ||
lower limits for each end-effector joint where N is the arm DOF. | ||
:property cameras: The cameras and where they should go. The key is the | ||
prefix to match in the sensor names. For example, a key of `"head"` | ||
will match sensors `"head_rgb"` and `"head_depth"` | ||
:property gripper_closed_state: All gripper joints must achieve this | ||
state for the gripper to be considered closed. | ||
:property gripper_open_state: All gripper joints must achieve this | ||
state for the gripper to be considered open. | ||
:property ee_constraint: A (ee_count, 2, N) shaped array specifying the upper and lower limits for each end-effector joint where N is the arm DOF. | ||
:property cameras: The cameras and where they should go. The key is the prefix to match in the sensor names. For example, a key of `"head"`will match sensors `"head_rgb"` and `"head_depth"` | ||
:property gripper_closed_state: All gripper joints must achieve this state for the gripper to be considered closed. | ||
:property gripper_open_state: All gripper joints must achieve this state for the gripper to be considered open. | ||
:property gripper_state_eps: Error margin for detecting whether gripper is closed. | ||
:property arm_mtr_pos_gain: The position gain of the arm motor. | ||
:property arm_mtr_vel_gain: The velocity gain of the arm motor. | ||
:property arm_mtr_max_impulse: The maximum impulse of the arm motor. | ||
:property wheel_mtr_pos_gain: The position gain of the wheeled motor (if | ||
there are wheels). | ||
:property wheel_mtr_vel_gain: The velocity gain of the wheel motor (if | ||
there are wheels). | ||
:property wheel_mtr_max_impulse: The maximum impulse of the wheel motor (if | ||
there are wheels). | ||
:property wheel_mtr_pos_gain: The position gain of the wheeled motor (if there are wheels). | ||
:property wheel_mtr_vel_gain: The velocity gain of the wheel motor (if there are wheels). | ||
:property wheel_mtr_max_impulse: The maximum impulse of the wheel motor (if there are wheels). | ||
:property base_offset: The offset of the root transform from the center ground point for navmesh kinematic control. | ||
:property ee_count: how many end effectors | ||
""" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I.e., this will most probably cause a problem -- it should be indented like before, or on a single line.