-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BE] - Deprecate colab #1742
[BE] - Deprecate colab #1742
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Alex!
One quick question: are those jupyter notebook runnable?
|
||
HTML( | ||
'<iframe src="https://drive.google.com/file/d/1ltrse38i8pnJPGAXlThylcdy8PMjUMKh/preview" width="640" height="480" allow="autoplay"></iframe>' | ||
# NOTE: this file is unreachable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Alex, thank you for this PR!
Do we want to remove this given that we cannot reach this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ASzot I think you set this up originally. Is this file somewhere? Is it important?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge the current changes and we can remove or re-link the video later.
Yes, I have been running them locally to test the changes. I didn't write the tutorials, so there may be some content decay, but the cells all run and produce output with no show-stopping runtime errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* rename 'colabs/' to 'notebooks/' and refactor links * refactor colabs to running Jupyter notebooks
* rename 'colabs/' to 'notebooks/' and refactor links * refactor colabs to running Jupyter notebooks
* rename 'colabs/' to 'notebooks/' and refactor links * refactor colabs to running Jupyter notebooks
Motivation and Context
Colab is a shifting foundtation for hosting tutorials. Back-end changes require updates to installers and scripts resulting in tutorial downtime and extra developer bandwidth load. Instead, we opt to deprecate Colab support and convert existing tutorials to locally-executable Jupyter notebooks.
examples/tutorials/colabs/ directory renamed to examples/tutorials/notebooks/
NOTE: partner habitat-sim PR: facebookresearch/habitat-sim#2298
How Has This Been Tested
Locally ran the Jupyter notebooks
Types of changes
Checklist