Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--Test fixes to support semantic sensor updates #1801

Merged
merged 4 commits into from
Feb 27, 2024
Merged

Conversation

jturner65
Copy link
Contributor

@jturner65 jturner65 commented Feb 9, 2024

Motivation and Context

This PR fixes tests that reference the hardcoded stage ID in habitat-sim. This value has changed from -1 to 0, to facilitate the object id/panoptic sensor capabilities being introduced in this PR
Until the above referenced Sim PR is merged, however, this PR will fail on test_sim_utils.py

The stage ID value is now backed by a constant habitat_sim.stage_id. This PR aims to replace all of the hard-coded numeric references to the stage with this constant.

How Has This Been Tested

Locally with above-referenced Habitat-Sim PR.

Types of changes

  • [Bug Fix] (non-breaking change which fixes an issue)

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@jturner65 jturner65 requested a review from aclegg3 February 9, 2024 18:57
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 9, 2024
@jturner65 jturner65 force-pushed the SemanticSensorUpdates branch from 297586e to f36616d Compare February 13, 2024 14:28
Hardcoded values referring to the stage needed to be changed.
@jturner65 jturner65 force-pushed the SemanticSensorUpdates branch from f36616d to 5a9f1c7 Compare February 26, 2024 17:55
@jturner65 jturner65 marked this pull request as ready for review February 26, 2024 18:02
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, hopefully we caught them all in one pass. 🙂

@jturner65 jturner65 merged commit 9fb686c into main Feb 27, 2024
4 checks passed
@jturner65 jturner65 deleted the SemanticSensorUpdates branch February 27, 2024 03:15
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
* --fix test_sim_utils
Hardcoded values referring to the stage needed to be changed.
* --remove magic numbers for test_robot_wrapper ids
* --modify reference to stage ID from magic number to habitat_sim.stage_id constant.
* --further references
HHYHRHY pushed a commit to SgtVincent/EMOS that referenced this pull request Aug 31, 2024
* --fix test_sim_utils
Hardcoded values referring to the stage needed to be changed.
* --remove magic numbers for test_robot_wrapper ids
* --modify reference to stage ID from magic number to habitat_sim.stage_id constant.
* --further references
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants