HITL: Add typing annotations to AppService #1802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
mosra
reviewed
Feb 9, 2024
| from habitat_hitl.environment.controllers.controller_abc import GuiController | ||
| from habitat_hitl.environment.episode_helper import EpisodeHelper | ||
| from habitat_sim.gfx import DebugLineRender | ||
|
|
||
|
|
||
| # Helpers to provide to AppState classes, provided by the underlying SandboxDriver | ||
| class AppService: | ||
| def __init__( | ||
| self, | ||
| config, |
There was a problem hiding this comment.
May want to do this to force the arguments to be always keywords. The docs generator will pick that up and show in the output as well.
Suggested change
| config, | |
| *, config, |
There was a problem hiding this comment.
Neat trick! Thank you!
eundersander
approved these changes
Feb 9, 2024
henrysamer
pushed a commit
that referenced
this pull request
Feb 21, 2024
* Add type annotations to app_service. * Propagate AppService type annotations to the apps. * Move displaced comment. * Force keyword argument usage in AppService constructior.
dannymcy
pushed a commit
to dannymcy/habitat-lab
that referenced
this pull request
Jul 8, 2024
* Add type annotations to app_service. * Propagate AppService type annotations to the apps. * Move displaced comment. * Force keyword argument usage in AppService constructior.
HHYHRHY
pushed a commit
to SgtVincent/EMOS
that referenced
this pull request
Aug 31, 2024
* Add type annotations to app_service. * Propagate AppService type annotations to the apps. * Move displaced comment. * Force keyword argument usage in AppService constructior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The
AppServiceobject acts a dependency injection container for HITL components. Its dependencies are opaque and difficult to track.This changeset adds type annotations to this object.
How Has This Been Tested
Pre-commit and local run.
Types of changes
Checklist