-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DebugVisualizer generic 'peek' function #1834
Conversation
…o-save in favor of DebugObservation interface
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left some minor comments.
) | ||
subject = subject_obj | ||
|
||
if subject_bb is None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: This could be a calculate_subject_bounding_box()
method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: I'll refactor this later. I'm adding such a function in another PR.
* replace specific peek functions with generic interface and remove auto-save in favor of DebugObservation interface
* replace specific peek functions with generic interface and remove auto-save in favor of DebugObservation interface
Motivation and Context
Breaking Change: removed functions from
DebugVisualizer
peek_rigid_object
peek_articulated_object
peek_scene
This PR removes the previous type specific
"peek_*"
functions in favor of a single new generic"peek"
function taking all reasonable inputs to describe the subject of the peek.This function will take
ManagedObject
, integer object id, or string object instance handle.For example, given a rigid or articulated object
my_object
, the following are all valid:dbv.peek(my_object)
dbv.peek(my_object.object_id)
dbv.peek(my_object.handle)
This function will also accept string aliases
"scene"
and"stage"
to set the subject as the full contents of the current scene:dbv.peek("stage")
dbv.peek("scene")
Finally, the peek now returns a single
DebugObservation
, so both auto-saving feature andshow
variable are removed in favor of the standard interface ofDebugObservation.show()
andDebugObservation.save(directory_path)
.How Has This Been Tested
Down-stream code refactored to use new interface.
Locally with all variations in a testing environment.
Types of changes
Checklist