Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HITL - Add typing for comms data dictionaries #1874

Merged
merged 7 commits into from
Mar 26, 2024
Merged

HITL - Add typing for comms data dictionaries #1874

merged 7 commits into from
Mar 26, 2024

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Mar 22, 2024

Motivation and Context

This changeset adds typing for common communication data dictionaries:

  • Keyframe
  • ClientState
  • ConnectionRecord

How Has This Been Tested

Tested locally.

Types of changes

  • [Refactoring] Large changes to the code that improve its functionality or performance

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • [ x] I have added tests to cover my changes if required.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 22, 2024
aclegg3
aclegg3 approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+docs 👏

@0mdc 0mdc merged commit dd2800a into main Mar 26, 2024
4 checks passed
@0mdc 0mdc deleted the 0mdc/data_dict_typing branch March 26, 2024 21:18
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jun 26, 2024
@0mdc @dannymcy
HITL - Add typing for comms data dictionaries (facebookresearch#1874)
9a29cc2 
* Add typing file.

* Add types to interprocess_record data dicts.

* Add typing to keyframe_utils

* Add typing to RemoteClientState.

* Add more types to networking_process

* Add types to ClientHelper.

* Add docstring clarification.
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@0mdc
HITL - Add typing for comms data dictionaries (facebookresearch#1874)
0781faa 
* Add typing file.

* Add types to interprocess_record data dicts.

* Add typing to keyframe_utils

* Add typing to RemoteClientState.

* Add more types to networking_process

* Add types to ClientHelper.

* Add docstring clarification.
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@0mdc @dannymcy
HITL - Add typing for comms data dictionaries (facebookresearch#1874)
f014a24 
* Add typing file.

* Add types to interprocess_record data dicts.

* Add typing to keyframe_utils

* Add typing to RemoteClientState.

* Add more types to networking_process

* Add types to ClientHelper.

* Add docstring clarification.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclegg3 aclegg3 aclegg3 approved these changes

@jturner65 jturner65 Awaiting requested review from jturner65

@jimmytyyang jimmytyyang Awaiting requested review from jimmytyyang

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0mdc @aclegg3 @facebook-github-bot